Skip to content
This repository was archived by the owner on Nov 27, 2023. It is now read-only.

Commit 58e10a7

Browse files
committed
Display warning in docker compose down if nothing to remove (no container, no network)
For reference, `docker-compose` displays `WARNING: Network sentences_default not found` Signed-off-by: Guillaume Tardif <[email protected]>
1 parent ec26ba5 commit 58e10a7

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

local/compose/down.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ import (
3434

3535
func (s *composeService) Down(ctx context.Context, projectName string, options compose.DownOptions) error {
3636
w := progress.ContextWriter(ctx)
37+
resourceToRemove := false
3738

3839
if options.Project == nil {
3940
project, err := s.projectFromContainerLabels(ctx, projectName)
@@ -51,6 +52,9 @@ func (s *composeService) Down(ctx context.Context, projectName string, options c
5152
if err != nil {
5253
return err
5354
}
55+
if len(containers) > 0 {
56+
resourceToRemove = true
57+
}
5458

5559
err = InReverseDependencyOrder(ctx, options.Project, func(c context.Context, service types.ServiceConfig) error {
5660
serviceContainers, others := containers.split(isService(service.Name))
@@ -80,12 +84,16 @@ func (s *composeService) Down(ctx context.Context, projectName string, options c
8084

8185
eg, _ := errgroup.WithContext(ctx)
8286
for _, n := range networks {
87+
resourceToRemove = true
8388
networkID := n.ID
8489
networkName := n.Name
8590
eg.Go(func() error {
8691
return s.ensureNetworkDown(ctx, networkID, networkName)
8792
})
8893
}
94+
if !resourceToRemove {
95+
w.Event(progress.NewEvent(projectName, progress.Done, "Warning: No resource found to remove"))
96+
}
8997
return eg.Wait()
9098
}
9199

0 commit comments

Comments
 (0)