Skip to content
This repository was archived by the owner on Nov 27, 2023. It is now read-only.

Commit f438992

Browse files
authored
Merge pull request #1770 from ndeloof/fix_network_alias_test
fix broken network_alias_test
2 parents 21a4af3 + e641ffa commit f438992

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

local/compose/create.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,6 @@ func (s *composeService) getCreateOptions(ctx context.Context, p *types.Project,
284284
}
285285

286286
var networkConfig *network.NetworkingConfig
287-
// TODO use network with highest priority, attribute is missing from compose-go
288287
for _, id := range service.NetworksByPriority() {
289288
net := p.Networks[id]
290289
config := service.Networks[id]

local/e2e/compose/fixtures/network-alias/compose.yaml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,6 @@ services:
66
container2:
77
image: nginx
88
networks:
9-
foo:
9+
default:
1010
aliases:
1111
- alias-of-container2
12-
13-
networks:
14-
foo:
15-
name: bar

0 commit comments

Comments
 (0)