Make sure PR builds don't break with S3 upload

CircleCI is set up to *not* copy credentials into build for PR branches.  So this was causing builds to break.  This PR fixes that by moving the minio set up into the deployment steps of release and master branches.

Author: David Chung

circle.yml

@@ -45,10 +45,6 @@ test:
   post:
     # Report to codecov
     - cd $WORKDIR && bash <(curl -s https://codecov.io/bash)
-    # Install minio.io for S3 bucket uploads
-    - wget https://dl.minio.io/client/mc/release/linux-amd64/mc && chmod a+x ./mc && sudo cp ./mc /usr/local/bin
-    - mc config host add $S3_MINIO https://s3.amazonaws.com $S3_KEY_ID $S3_SECRET_KEY S3v4
-    - mc policy download $S3_BUCKET
 
 deployment:
   pr:
@@ -61,6 +57,10 @@ deployment:
     commands:
       - docker login -e $DOCKER_HUB_EMAIL -u $DOCKER_HUB_USER -p $DOCKER_HUB_PASSWD
       - DOCKER_PUSH=true DOCKER_TAG_LATEST=false DOCKER_TAG=$(echo $CIRCLE_BRANCH | awk -F - '{print $2}') DOCKER_BUILD_FLAGS="--rm=false" make build-docker
+      # Install minio.io for S3 bucket uploads
+      - wget https://dl.minio.io/client/mc/release/linux-amd64/mc && chmod a+x ./mc && sudo cp ./mc /usr/local/bin
+      - mc config host add $S3_MINIO https://s3.amazonaws.com $S3_KEY_ID $S3_SECRET_KEY S3v4
+      - mc policy download $S3_BUCKET
       - tar cvfz ./$S3_BUILD_PR -C build .
       - mc cp ./$S3_BUILD_PR $S3_BUCKET/
 
@@ -69,6 +69,10 @@ deployment:
     commands:
       - docker login -e $DOCKER_HUB_EMAIL -u $DOCKER_HUB_USER -p $DOCKER_HUB_PASSWD
       - DOCKER_PUSH=true DOCKER_TAG_LATEST=true DOCKER_TAG="master-$CIRCLE_BUILD_NUM" DOCKER_BUILD_FLAGS="--rm=false" make build-docker
+      # Install minio.io for S3 bucket uploads
+      - wget https://dl.minio.io/client/mc/release/linux-amd64/mc && chmod a+x ./mc && sudo cp ./mc /usr/local/bin
+      - mc config host add $S3_MINIO https://s3.amazonaws.com $S3_KEY_ID $S3_SECRET_KEY S3v4
+      - mc policy download $S3_BUCKET
       - tar cvfz ./$S3_BUILD_MASTER -C build .
       - mc cp ./$S3_BUILD_MASTER $S3_BUCKET/
       - mc cp ./$S3_BUILD_MASTER $S3_BUCKET/infrakit-latest.gz