Skip to content
This repository was archived by the owner on Jan 21, 2020. It is now read-only.

Commit 190e269

Browse files
author
David Chung
authored
Disable full container builds for PR branch (#483)
Signed-off-by: David Chung <[email protected]>
1 parent 8fb2de6 commit 190e269

File tree

2 files changed

+14
-5
lines changed

2 files changed

+14
-5
lines changed

circle.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,12 @@ test:
4545
post:
4646
# Report to codecov
4747
- cd $WORKDIR && bash <(curl -s https://codecov.io/bash)
48-
48+
4949
deployment:
5050
pr:
5151
branch: /pull\/.*/
5252
commands:
53-
- DOCKER_BUILD_FLAGS="--rm=false" make build-docker
53+
- # DISABLED TO SPEED UP PR Process: DOCKER_BUILD_FLAGS="--rm=false" make build-docker
5454

5555
release:
5656
branch: /release-.*/

pkg/broker/client/sse_test.go

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,10 @@ func TestBrokerSubscriberExactMatchTopic(t *testing.T) {
346346
require.NoError(t, m.Decode(&val))
347347
received1 <- val
348348
} else {
349-
close(received1)
349+
if received1 != nil {
350+
close(received1)
351+
received1 = nil
352+
}
350353
}
351354
}
352355
}
@@ -365,7 +368,10 @@ func TestBrokerSubscriberExactMatchTopic(t *testing.T) {
365368
require.NoError(t, m.Decode(&val))
366369
received2 <- val
367370
} else {
368-
close(received2)
371+
if received2 != nil {
372+
close(received2)
373+
received2 = nil
374+
}
369375
}
370376
}
371377
}
@@ -384,7 +390,10 @@ func TestBrokerSubscriberExactMatchTopic(t *testing.T) {
384390
require.NoError(t, m.Decode(&val))
385391
received3 <- val
386392
} else {
387-
close(received3)
393+
if received3 != nil {
394+
close(received3)
395+
received3 = nil
396+
}
388397
}
389398
}
390399
}

0 commit comments

Comments
 (0)