Skip to content
This repository was archived by the owner on Sep 12, 2018. It is now read-only.

Commit 3a89bde

Browse files
author
Matthias Erll
committed
Fix auth_basic exemption in sample nginx.conf
1 parent 97234d7 commit 3a89bde

File tree

3 files changed

+11
-16
lines changed

3 files changed

+11
-16
lines changed

contrib/nginx/docker-registry.conf

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
proxy_pass http://docker-registry;
2+
proxy_set_header Host $http_host;
3+
proxy_set_header X-Real-IP $remote_addr;
4+
proxy_set_header Authorization "";
5+
proxy_read_timeout 900;

contrib/nginx.conf renamed to contrib/nginx/nginx.conf

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,6 @@ server {
2424
ssl_certificate /etc/ssl/certs/docker-registry;
2525
ssl_certificate_key /etc/ssl/private/docker-registry;
2626

27-
proxy_set_header Host $http_host; # required for docker client's sake
28-
proxy_set_header X-Real-IP $remote_addr; # pass on real client's IP
29-
proxy_set_header Authorization ""; # see https://github.com/dotcloud/docker-registry/issues/170
30-
3127
client_max_body_size 0; # disable any limits to avoid HTTP 413 for large image uploads
3228

3329
# required to avoid HTTP 411: see Issue #1486 (https://github.com/dotcloud/docker/issues/1486)
@@ -38,19 +34,18 @@ server {
3834
}
3935

4036
location / {
41-
proxy_pass http://docker-registry;
42-
proxy_set_header Host $host;
43-
proxy_read_timeout 900;
44-
4537
auth_basic "Restricted";
4638
auth_basic_user_file docker-registry.htpasswd;
39+
include docker-registry.conf
4740
}
4841

4942
location /_ping {
5043
auth_basic off;
44+
include docker-registry.conf
5145
}
5246

5347
location /v1/_ping {
5448
auth_basic off;
49+
include docker-registry.conf
5550
}
5651
}

contrib/nginx_1-3-9.conf renamed to contrib/nginx/nginx_1-3-9.conf

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,29 +22,24 @@ server {
2222
ssl_certificate /etc/ssl/certs/docker-registry;
2323
ssl_certificate_key /etc/ssl/private/docker-registry;
2424

25-
proxy_set_header Host $http_host; # required for docker client's sake
26-
proxy_set_header X-Real-IP $remote_addr; # pass on real client's IP
27-
proxy_set_header Authorization ""; # see https://github.com/dotcloud/docker-registry/issues/170
28-
2925
client_max_body_size 0; # disable any limits to avoid HTTP 413 for large image uploads
3026

3127
# required to avoid HTTP 411: see Issue #1486 (https://github.com/dotcloud/docker/issues/1486)
3228
chunked_transfer_encoding on;
3329

3430
location / {
35-
proxy_pass http://docker-registry;
36-
proxy_set_header Host $host;
37-
proxy_read_timeout 900;
38-
3931
auth_basic "Restricted";
4032
auth_basic_user_file docker-registry.htpasswd;
33+
include docker-registry.conf
4134
}
4235

4336
location /_ping {
4437
auth_basic off;
38+
include docker-registry.conf
4539
}
4640

4741
location /v1/_ping {
4842
auth_basic off;
43+
include docker-registry.conf
4944
}
5045
}

0 commit comments

Comments
 (0)