Skip to content

Commit 49776e3

Browse files
committed
Adjust test to instead use the same example manifest for consistency
1 parent 5cfb31e commit 49776e3

File tree

2 files changed

+17
-45
lines changed

2 files changed

+17
-45
lines changed

manifest/example_test.go

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,18 @@ s390x-GitCommit: b6c460e7cd79b595267870a98013ec3078b490df
5454
i386-GitFetch: refs/heads/i386
5555
ppc64le-Directory: 1.5/ppc64le
5656
57+
Tags: 1.5-alpine
58+
GitCommit: d7e2a8d90a9b8f5dfd5bcd428e0c33b68c40cc19
59+
Directory: 1.5
60+
File: Dockerfile.alpine
61+
s390x-File: Dockerfile.alpine.s390x.bad-boy
62+
5763
SharedTags: raspbian
5864
GitCommit: deadbeefdeadbeefdeadbeefdeadbeefdeadbeef
5965
Tags: raspbian-s390x
6066
Architectures: s390x, i386
67+
File: Dockerfile-raspbian
68+
s390x-File: Dockerfile
6169
6270
6371
`)))
@@ -113,15 +121,24 @@ i: g@h j
113121
// ppc64le-Directory: 1.5/ppc64le
114122
// s390x-GitCommit: b6c460e7cd79b595267870a98013ec3078b490df
115123
//
124+
// Tags: 1.5-alpine
125+
// GitCommit: d7e2a8d90a9b8f5dfd5bcd428e0c33b68c40cc19
126+
// Directory: 1.5
127+
// File: Dockerfile.alpine
128+
// s390x-File: Dockerfile.alpine.s390x.bad-boy
129+
//
116130
// Tags: raspbian-s390x
117131
// SharedTags: raspbian
118132
// Architectures: i386, s390x
119133
// GitCommit: deadbeefdeadbeefdeadbeefdeadbeefdeadbeef
134+
// File: Dockerfile-raspbian
135+
// s390x-File: Dockerfile
120136
//
121137
// Shared Tag Groups:
122138
//
123139
// - latest
124140
// - 1.6.1, 1.6, 1
141+
// - 1.5-alpine
125142
//
126143
// - 1.5.3-debian, 1.5-debian
127144
// - 1.5.3, 1.5

manifest/parse_test.go

Lines changed: 0 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -18,48 +18,3 @@ func TestParseError(t *testing.T) {
1818
t.Errorf("Unexpected error: %v", err)
1919
}
2020
}
21-
22-
func TestArchFile(t *testing.T) {
23-
tests := []struct {
24-
file string
25-
arch string
26-
expectedFile string
27-
}{{
28-
file: "",
29-
arch: manifest.DefaultArchitecture,
30-
expectedFile: "Dockerfile",
31-
}, {
32-
file: "Dockerfile",
33-
arch: manifest.DefaultArchitecture,
34-
expectedFile: "Dockerfile",
35-
}, {
36-
file: "Dockerfile-foo",
37-
arch: manifest.DefaultArchitecture,
38-
expectedFile: "Dockerfile-foo",
39-
}, {
40-
file: "Dockerfile-i386",
41-
arch: "i386",
42-
expectedFile: "Dockerfile-i386",
43-
},
44-
}
45-
46-
for _, test := range tests {
47-
manString := `Maintainers: Giuseppe Valente <[email protected]> (@7AC)
48-
GitCommit: abcdef
49-
`
50-
if test.arch != manifest.DefaultArchitecture {
51-
manString += test.arch + "-"
52-
}
53-
if test.file != "" {
54-
manString += "File: " + test.file
55-
}
56-
man, err := manifest.Parse2822(strings.NewReader(manString))
57-
if err != nil {
58-
t.Fatalf("Unexpected error: %v", err)
59-
}
60-
actualFile := man.Global.ArchFile(test.arch)
61-
if actualFile != test.expectedFile {
62-
t.Fatalf("Unexpected arch file: %s (expected %q)", actualFile, test.expectedFile)
63-
}
64-
}
65-
}

0 commit comments

Comments
 (0)