Skip to content

Commit 2ab877f

Browse files
committed
Enable rootless-extras on arm64 for 20.10+
1 parent 279ba9c commit 2ab877f

File tree

4 files changed

+27
-11
lines changed

4 files changed

+27
-11
lines changed

20.10-rc/dind-rootless/Dockerfile

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

20.10/dind-rootless/Dockerfile

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

versions.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,8 @@
6565
"dockerUrl": "https://download.docker.com/linux/static/stable/armhf/docker-20.10.7.tgz"
6666
},
6767
"arm64v8": {
68-
"dockerUrl": "https://download.docker.com/linux/static/stable/aarch64/docker-20.10.7.tgz"
68+
"dockerUrl": "https://download.docker.com/linux/static/stable/aarch64/docker-20.10.7.tgz",
69+
"rootlessExtrasUrl": "https://download.docker.com/linux/static/stable/aarch64/docker-rootless-extras-20.10.7.tgz"
6970
},
7071
"windows-amd64": {
7172
"dockerUrl": "https://download.docker.com/win/static/stable/x86_64/docker-20.10.7.zip"
@@ -95,7 +96,8 @@
9596
"dockerUrl": "https://download.docker.com/linux/static/test/armhf/docker-20.10.0-rc2.tgz"
9697
},
9798
"arm64v8": {
98-
"dockerUrl": "https://download.docker.com/linux/static/test/aarch64/docker-20.10.0-rc2.tgz"
99+
"dockerUrl": "https://download.docker.com/linux/static/test/aarch64/docker-20.10.0-rc2.tgz",
100+
"rootlessExtrasUrl": "https://download.docker.com/linux/static/test/aarch64/docker-rootless-extras-20.10.0-rc2.tgz"
99101
}
100102
},
101103
"dindCommit": "42b1175eda071c0e9121e1d64345928384a93df1",

versions.sh

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -122,16 +122,24 @@ for version in "${versions[@]}"; do
122122
continue # Windows doesn't have rootless extras :)
123123
fi
124124

125-
rootlessExtrasUrl="https://download.docker.com/linux/static/$channel/$arch/docker-rootless-extras-$fullVersion.tgz"
126-
# https://github.com/docker/docker-ce/blob/8fb3bb7b2210789a4471c017561c1b0de0b4f145/components/engine/hack/make/binary-daemon#L24
127-
# "vpnkit is amd64-only" ... for now??
128-
if [ "$bashbrewArch" = 'amd64' ] && wget --quiet --spider "$rootlessExtrasUrl" &> /dev/null; then
129-
export rootlessExtrasUrl
130-
doc="$(
131-
jq <<<"$doc" -c \
132-
'.arches[env.bashbrewArch].rootlessExtrasUrl = env.rootlessExtrasUrl'
133-
)"
125+
if [ "$rcVersion" = '19.03' ] && [ "$bashbrewArch" != 'amd64' ]; then
126+
# https://github.com/moby/moby/blob/v19.03.15/hack/make/binary-daemon#L24
127+
# "vpnkit is amd64 only"
128+
continue
134129
fi
130+
# https://github.com/moby/moby/blob/v20.10.7/hack/make/binary-daemon#L24
131+
# "vpnkit is available for x86_64 and aarch64"
132+
case "$bashbrewArch" in
133+
amd64 | arm64v8)
134+
rootlessExtrasUrl="https://download.docker.com/linux/static/$channel/$arch/docker-rootless-extras-$fullVersion.tgz"
135+
if wget --quiet --spider "$rootlessExtrasUrl" &> /dev/null; then
136+
export rootlessExtrasUrl
137+
doc="$(jq <<<"$doc" -c '
138+
.arches[env.bashbrewArch].rootlessExtrasUrl = env.rootlessExtrasUrl
139+
')"
140+
fi
141+
;;
142+
esac
135143
done
136144

137145
# order here controls the order of the library/ file

0 commit comments

Comments
 (0)