Skip to content

Commit 9dfba41

Browse files
authored
Merge pull request #273 from infosiftr/no-separate-rootlesskit
Remove explicit rootlesskit version
2 parents d4b2a80 + 5bccde5 commit 9dfba41

File tree

4 files changed

+12
-84
lines changed

4 files changed

+12
-84
lines changed

19.03-rc/dind-rootless/Dockerfile

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -35,33 +35,15 @@ RUN set -eux; \
3535
--file rootless.tgz \
3636
--strip-components 1 \
3737
--directory /usr/local/bin/ \
38+
'docker-rootless-extras/rootlesskit' \
39+
'docker-rootless-extras/rootlesskit-docker-proxy' \
3840
'docker-rootless-extras/vpnkit' \
3941
; \
4042
rm rootless.tgz; \
4143
\
42-
# we download/build rootlesskit separately to get a newer release
43-
# rootlesskit --version; \
44+
rootlesskit --version; \
4445
vpnkit --version
4546

46-
# https://github.com/rootless-containers/rootlesskit/releases
47-
ENV ROOTLESSKIT_VERSION 0.11.0
48-
49-
RUN set -eux; \
50-
apk add --no-cache --virtual .rootlesskit-build-deps \
51-
go \
52-
libc-dev \
53-
; \
54-
wget -O rootlesskit.tgz "https://github.com/rootless-containers/rootlesskit/archive/v${ROOTLESSKIT_VERSION}.tar.gz"; \
55-
export GOPATH='/go'; mkdir "$GOPATH"; \
56-
mkdir -p "$GOPATH/src/github.com/rootless-containers/rootlesskit"; \
57-
tar --extract --file rootlesskit.tgz --directory "$GOPATH/src/github.com/rootless-containers/rootlesskit" --strip-components 1; \
58-
rm rootlesskit.tgz; \
59-
go build -o /usr/local/bin/rootlesskit github.com/rootless-containers/rootlesskit/cmd/rootlesskit; \
60-
go build -o /usr/local/bin/rootlesskit-docker-proxy github.com/rootless-containers/rootlesskit/cmd/rootlesskit-docker-proxy; \
61-
rm -rf "$GOPATH"; \
62-
apk del --no-network .rootlesskit-build-deps; \
63-
rootlesskit --version
64-
6547
# pre-create "/var/lib/docker" for our rootless user
6648
RUN set -eux; \
6749
mkdir -p /home/rootless/.local/share/docker; \

19.03/dind-rootless/Dockerfile

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -35,33 +35,15 @@ RUN set -eux; \
3535
--file rootless.tgz \
3636
--strip-components 1 \
3737
--directory /usr/local/bin/ \
38+
'docker-rootless-extras/rootlesskit' \
39+
'docker-rootless-extras/rootlesskit-docker-proxy' \
3840
'docker-rootless-extras/vpnkit' \
3941
; \
4042
rm rootless.tgz; \
4143
\
42-
# we download/build rootlesskit separately to get a newer release
43-
# rootlesskit --version; \
44+
rootlesskit --version; \
4445
vpnkit --version
4546

46-
# https://github.com/rootless-containers/rootlesskit/releases
47-
ENV ROOTLESSKIT_VERSION 0.11.0
48-
49-
RUN set -eux; \
50-
apk add --no-cache --virtual .rootlesskit-build-deps \
51-
go \
52-
libc-dev \
53-
; \
54-
wget -O rootlesskit.tgz "https://github.com/rootless-containers/rootlesskit/archive/v${ROOTLESSKIT_VERSION}.tar.gz"; \
55-
export GOPATH='/go'; mkdir "$GOPATH"; \
56-
mkdir -p "$GOPATH/src/github.com/rootless-containers/rootlesskit"; \
57-
tar --extract --file rootlesskit.tgz --directory "$GOPATH/src/github.com/rootless-containers/rootlesskit" --strip-components 1; \
58-
rm rootlesskit.tgz; \
59-
go build -o /usr/local/bin/rootlesskit github.com/rootless-containers/rootlesskit/cmd/rootlesskit; \
60-
go build -o /usr/local/bin/rootlesskit-docker-proxy github.com/rootless-containers/rootlesskit/cmd/rootlesskit-docker-proxy; \
61-
rm -rf "$GOPATH"; \
62-
apk del --no-network .rootlesskit-build-deps; \
63-
rootlesskit --version
64-
6547
# pre-create "/var/lib/docker" for our rootless user
6648
RUN set -eux; \
6749
mkdir -p /home/rootless/.local/share/docker; \

20.10-rc/dind-rootless/Dockerfile

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -35,33 +35,15 @@ RUN set -eux; \
3535
--file rootless.tgz \
3636
--strip-components 1 \
3737
--directory /usr/local/bin/ \
38+
'docker-rootless-extras/rootlesskit' \
39+
'docker-rootless-extras/rootlesskit-docker-proxy' \
3840
'docker-rootless-extras/vpnkit' \
3941
; \
4042
rm rootless.tgz; \
4143
\
42-
# we download/build rootlesskit separately to get a newer release
43-
# rootlesskit --version; \
44+
rootlesskit --version; \
4445
vpnkit --version
4546

46-
# https://github.com/rootless-containers/rootlesskit/releases
47-
ENV ROOTLESSKIT_VERSION 0.11.0
48-
49-
RUN set -eux; \
50-
apk add --no-cache --virtual .rootlesskit-build-deps \
51-
go \
52-
libc-dev \
53-
; \
54-
wget -O rootlesskit.tgz "https://github.com/rootless-containers/rootlesskit/archive/v${ROOTLESSKIT_VERSION}.tar.gz"; \
55-
export GOPATH='/go'; mkdir "$GOPATH"; \
56-
mkdir -p "$GOPATH/src/github.com/rootless-containers/rootlesskit"; \
57-
tar --extract --file rootlesskit.tgz --directory "$GOPATH/src/github.com/rootless-containers/rootlesskit" --strip-components 1; \
58-
rm rootlesskit.tgz; \
59-
go build -o /usr/local/bin/rootlesskit github.com/rootless-containers/rootlesskit/cmd/rootlesskit; \
60-
go build -o /usr/local/bin/rootlesskit-docker-proxy github.com/rootless-containers/rootlesskit/cmd/rootlesskit-docker-proxy; \
61-
rm -rf "$GOPATH"; \
62-
apk del --no-network .rootlesskit-build-deps; \
63-
rootlesskit --version
64-
6547
# pre-create "/var/lib/docker" for our rootless user
6648
RUN set -eux; \
6749
mkdir -p /home/rootless/.local/share/docker; \

Dockerfile-dind-rootless.template

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -50,33 +50,15 @@ RUN set -eux; \
5050
--file rootless.tgz \
5151
--strip-components 1 \
5252
--directory /usr/local/bin/ \
53+
'docker-rootless-extras/rootlesskit' \
54+
'docker-rootless-extras/rootlesskit-docker-proxy' \
5355
'docker-rootless-extras/vpnkit' \
5456
; \
5557
rm rootless.tgz; \
5658
\
57-
# we download/build rootlesskit separately to get a newer release
58-
# rootlesskit --version; \
59+
rootlesskit --version; \
5960
vpnkit --version
6061

61-
# https://github.com/rootless-containers/rootlesskit/releases
62-
ENV ROOTLESSKIT_VERSION 0.11.0
63-
64-
RUN set -eux; \
65-
apk add --no-cache --virtual .rootlesskit-build-deps \
66-
go \
67-
libc-dev \
68-
; \
69-
wget -O rootlesskit.tgz "https://github.com/rootless-containers/rootlesskit/archive/v${ROOTLESSKIT_VERSION}.tar.gz"; \
70-
export GOPATH='/go'; mkdir "$GOPATH"; \
71-
mkdir -p "$GOPATH/src/github.com/rootless-containers/rootlesskit"; \
72-
tar --extract --file rootlesskit.tgz --directory "$GOPATH/src/github.com/rootless-containers/rootlesskit" --strip-components 1; \
73-
rm rootlesskit.tgz; \
74-
go build -o /usr/local/bin/rootlesskit github.com/rootless-containers/rootlesskit/cmd/rootlesskit; \
75-
go build -o /usr/local/bin/rootlesskit-docker-proxy github.com/rootless-containers/rootlesskit/cmd/rootlesskit-docker-proxy; \
76-
rm -rf "$GOPATH"; \
77-
apk del --no-network .rootlesskit-build-deps; \
78-
rootlesskit --version
79-
8062
# pre-create "/var/lib/docker" for our rootless user
8163
RUN set -eux; \
8264
mkdir -p /home/rootless/.local/share/docker; \

0 commit comments

Comments
 (0)