build: display build details link

Signed-off-by: CrazyMax <[email protected]>

Author: crazy-max

build/build.go

@@ -26,6 +26,7 @@ import (
 	"github.com/docker/buildx/builder"
 	"github.com/docker/buildx/driver"
 	"github.com/docker/buildx/localstate"
+	"github.com/docker/buildx/util/desktop"
 	"github.com/docker/buildx/util/dockerutil"
 	"github.com/docker/buildx/util/imagetools"
 	"github.com/docker/buildx/util/progress"
@@ -822,6 +823,7 @@ func BuildWithResultHandler(ctx context.Context, nodes []builder.Node, opt map[s
 
 			for i, dp := range dps {
 				i, dp, so := i, dp, *dp.so
+				node := nodes[dp.driverIndex]
 				if multiDriver {
 					for i, e := range so.Exports {
 						switch e.Type {
@@ -940,6 +942,14 @@ func BuildWithResultHandler(ctx context.Context, nodes []builder.Node, opt map[s
 							return res, nil
 						}
 					}, ch)
+					if node.Driver.Features(ctx)[driver.HistoryAPI] && desktop.BuildBackendEnabled() {
+						progress.WriteBuildDetail(w, k, progress.BuildDetail{
+							Builder: node.Builder,
+							Node:    node.Name,
+							Ref:     so.Ref,
+							Err:     err,
+						})
+					}
 					if err != nil {
 						return err
 					}

commands/bake.go

@@ -117,8 +117,12 @@ func runBake(dockerCli command.Cli, targets []string, in bakeOptions, cFlags com
 		progressTextDesc = fmt.Sprintf("building with %q instance using %s driver", b.Name, b.Driver)
 	}
 
-	printer, err := progress.NewPrinter(ctx2, os.Stderr, os.Stderr, cFlags.progress,
+	var printer *progress.Printer
+	printer, err = progress.NewPrinter(ctx2, os.Stderr, os.Stderr, cFlags.progress,
 		progress.WithDesc(progressTextDesc, progressConsoleDesc),
+		progress.WithOnClose(func() {
+			printBuildDetails(os.Stderr, printer.BuildDetails(), cFlags.progress)
+		}),
 	)
 	if err != nil {
 		return err

commands/build.go

@@ -252,6 +252,7 @@ func runBuild(dockerCli command.Cli, options buildOptions) (err error) {
 		),
 		progress.WithOnClose(func() {
 			printWarnings(os.Stderr, printer.Warnings(), progressMode)
+			printBuildDetails(os.Stderr, printer.BuildDetails(), progressMode)
 		}),
 	)
 	if err != nil {
@@ -843,3 +844,45 @@ func printValue(printer printFunc, version string, format string, res map[string
 	}
 	return printer([]byte(res["result.json"]), os.Stdout)
 }
+
+func printBuildDetails(w io.Writer, bds map[string]progress.BuildDetail, mode string) {
+	if len(bds) == 0 || mode == progress.PrinterModeQuiet {
+		return
+	}
+
+	bdURL := func(bd progress.BuildDetail) string {
+		return fmt.Sprintf("docker-desktop://dashboard/build/%s/%s/%s", bd.Builder, bd.Node, bd.Ref)
+	}
+
+	bdWithErr := func(bds map[string]progress.BuildDetail) *progress.BuildDetail {
+		var canceled map[string]struct{}
+		for t, bd := range bds {
+			if bd.Err != nil {
+				if strings.HasSuffix(bd.Err.Error(), "context canceled") {
+					if canceled == nil {
+						canceled = make(map[string]struct{})
+					}
+					canceled[t] = struct{}{}
+					continue
+				}
+				return &bd
+			}
+		}
+		return nil
+	}(bds)
+
+	var out bytes.Buffer
+	out.WriteString("View build details: ")
+	if bdWithErr != nil {
+		out.WriteString(bdURL(*bdWithErr))
+	} else {
+		multiTargets := len(bds) > 1
+		for target, bd := range bds {
+			if multiTargets {
+				out.WriteString(fmt.Sprintf("\n  %s: ", target))
+			}
+			out.WriteString(bdURL(bd))
+		}
+	}
+	fmt.Fprintf(w, "\n%s\n", out.String())
+}

controller/pb/progress.go

@@ -19,6 +19,10 @@ func (w *writer) Write(status *client.SolveStatus) {
 	w.ch <- ToControlStatus(status)
 }
 
+func (w *writer) WriteBuildDetail(target string, bd progress.BuildDetail) {
+	return
+}
+
 func (w *writer) ValidateLogSource(digest.Digest, interface{}) bool {
 	return true
 }

util/desktop/desktop.go

@@ -0,0 +1,24 @@
+package desktop
+
+import (
+	"os"
+	"path/filepath"
+	"sync"
+)
+
+var (
+	bbEnabledOnce sync.Once
+	bbEnabled     bool
+)
+
+func BuildBackendEnabled() bool {
+	bbEnabledOnce.Do(func() {
+		home, err := os.UserHomeDir()
+		if err != nil {
+			return
+		}
+		_, err = os.Stat(filepath.Join(home, ".docker", "desktop-build", ".lastaccess"))
+		bbEnabled = err == nil
+	})
+	return bbEnabled
+}

util/progress/printer.go

@@ -33,6 +33,11 @@ type Printer struct {
 	warnings     []client.VertexWarning
 	logMu        sync.Mutex
 	logSourceMap map[digest.Digest]interface{}
+
+	// TODO: remove once we can use result context to pass build ref
+	//  see https://github.com/docker/buildx/pull/1861
+	buildDetailsMu sync.Mutex
+	buildDetails   map[string]BuildDetail
 }
 
 func (p *Printer) Wait() error {
@@ -143,6 +148,26 @@ func NewPrinter(ctx context.Context, w io.Writer, out console.File, mode string,
 	return pw, nil
 }
 
+type BuildDetail struct {
+	Builder string
+	Node    string
+	Ref     string
+	Err     error
+}
+
+func (p *Printer) WriteBuildDetail(target string, bd BuildDetail) {
+	p.buildDetailsMu.Lock()
+	if p.buildDetails == nil {
+		p.buildDetails = map[string]BuildDetail{}
+	}
+	p.buildDetails[target] = bd
+	p.buildDetailsMu.Unlock()
+}
+
+func (p *Printer) BuildDetails() map[string]BuildDetail {
+	return p.buildDetails
+}
+
 type printerOpts struct {
 	displayOpts []progressui.DisplaySolveStatusOpt
 

util/progress/writer.go

@@ -10,6 +10,7 @@ import (
 
 type Writer interface {
 	Write(*client.SolveStatus)
+	WriteBuildDetail(string, BuildDetail)
 	ValidateLogSource(digest.Digest, interface{}) bool
 	ClearLogSource(interface{})
 }
@@ -41,6 +42,10 @@ func Write(w Writer, name string, f func() error) {
 	})
 }
 
+func WriteBuildDetail(w Writer, target string, bd BuildDetail) {
+	w.WriteBuildDetail(target, bd)
+}
+
 func NewChannel(w Writer) (chan *client.SolveStatus, chan struct{}) {
 	ch := make(chan *client.SolveStatus)
 	done := make(chan struct{})