Skip to content

Commit d693e18

Browse files
committed
use a consistent alias for the docker client package
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1 parent b066ee1 commit d693e18

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

.golangci.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@ linters-settings:
4343
# buildkit errdefs package (or vice-versa).
4444
- pkg: "github.com/containerd/errdefs"
4545
alias: "cerrdefs"
46+
# Use a consistent alias to prevent confusion with "github.com/moby/buildkit/client"
47+
- pkg: "github.com/docker/docker/client"
48+
alias: "dockerclient"
4649
- pkg: "github.com/opencontainers/image-spec/specs-go/v1"
4750
alias: "ocispecs"
4851
- pkg: "github.com/opencontainers/go-digest"

util/dockerutil/api.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ package dockerutil
33
import (
44
"github.com/docker/cli/cli/command"
55
"github.com/docker/cli/cli/context/docker"
6-
"github.com/docker/docker/client"
6+
dockerclient "github.com/docker/docker/client"
77
)
88

99
// ClientAPI represents an active docker API object.
1010
type ClientAPI struct {
11-
client.APIClient
11+
dockerclient.APIClient
1212
}
1313

1414
func NewClientAPI(cli command.Cli, ep string) (*ClientAPI, error) {
@@ -36,7 +36,7 @@ func NewClientAPI(cli command.Cli, ep string) (*ClientAPI, error) {
3636
return nil, err
3737
}
3838

39-
ca.APIClient, err = client.NewClientWithOpts(clientOpts...)
39+
ca.APIClient, err = dockerclient.NewClientWithOpts(clientOpts...)
4040
if err != nil {
4141
return nil, err
4242
}

util/dockerutil/client.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import (
77

88
"github.com/docker/buildx/util/progress"
99
"github.com/docker/cli/cli/command"
10-
"github.com/docker/docker/client"
10+
dockerclient "github.com/docker/docker/client"
1111
)
1212

1313
// Client represents an active docker object.
@@ -24,7 +24,7 @@ func NewClient(cli command.Cli) *Client {
2424
}
2525

2626
// API returns a new docker API client.
27-
func (c *Client) API(name string) (client.APIClient, error) {
27+
func (c *Client) API(name string) (dockerclient.APIClient, error) {
2828
if name == "" {
2929
name = c.cli.CurrentContext()
3030
}

0 commit comments

Comments
 (0)