Skip to content

Commit bcbb464

Browse files
authored
Fixed the incorrect model names (#29)
1 parent 09ce7ca commit bcbb464

File tree

7 files changed

+18
-12
lines changed

7 files changed

+18
-12
lines changed

.github/workflows/pr-describe.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ jobs:
2626
- name: Get GitHub App token
2727
id: app-token
2828
if: env.HAS_APP_SECRETS == 'true'
29+
continue-on-error: true # Don't fail workflow if token generation fails
2930
uses: tibdex/github-app-token@3beb63f4bd073e61482598c45c71c1019b59b73a # v2
3031
with:
3132
app_id: ${{ secrets.CAGENT_REVIEWER_APP_ID }}
@@ -219,11 +220,12 @@ jobs:
219220
with:
220221
github-token: ${{ steps.app-token.outputs.token || github.token }}
221222
script: |
222-
const prNumber = ${{ steps.validate_pr.outputs.pr_number }};
223-
const title = '${{ steps.pr_details.outputs.title }}';
224-
const branch = '${{ steps.pr_details.outputs.branch }}';
225-
const base = '${{ steps.pr_details.outputs.base }}';
226-
const conclusion = '${{ steps.generate.conclusion }}';
223+
// Use context.issue.number directly - always available, doesn't depend on previous steps
224+
const prNumber = context.issue.number;
225+
const title = '${{ steps.pr_details.outputs.title }}' || 'Unknown';
226+
const branch = '${{ steps.pr_details.outputs.branch }}' || 'Unknown';
227+
const base = '${{ steps.pr_details.outputs.base }}' || 'Unknown';
228+
const conclusion = '${{ steps.generate.conclusion }}' || 'failure';
227229
228230
const summary = [
229231
'## 📝 PR Description Generator',

.github/workflows/review-pr.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,7 @@ jobs:
157157
- name: Generate GitHub App token
158158
if: steps.membership.outputs.is_member == 'true' && env.HAS_APP_SECRETS == 'true'
159159
id: app-token
160+
continue-on-error: true # Don't fail workflow if token generation fails
160161
uses: tibdex/github-app-token@3beb63f4bd073e61482598c45c71c1019b59b73a # v2
161162
with:
162163
app_id: ${{ secrets.CAGENT_REVIEWER_APP_ID }}
@@ -205,6 +206,7 @@ jobs:
205206
- name: Generate GitHub App token
206207
if: env.HAS_APP_SECRETS == 'true'
207208
id: app-token
209+
continue-on-error: true # Don't fail workflow if token generation fails
208210
uses: tibdex/github-app-token@3beb63f4bd073e61482598c45c71c1019b59b73a # v2
209211
with:
210212
app_id: ${{ secrets.CAGENT_REVIEWER_APP_ID }}
@@ -246,6 +248,7 @@ jobs:
246248
- name: Generate GitHub App token
247249
if: env.HAS_APP_SECRETS == 'true'
248250
id: app-token
251+
continue-on-error: true # Don't fail workflow if token generation fails
249252
uses: tibdex/github-app-token@3beb63f4bd073e61482598c45c71c1019b59b73a # v2
250253
with:
251254
app_id: ${{ secrets.CAGENT_REVIEWER_APP_ID }}

.github/workflows/security-scan.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ jobs:
3434
- name: Get GitHub App token
3535
id: app-token
3636
if: env.HAS_APP_SECRETS == 'true'
37+
continue-on-error: true # Don't fail workflow if token generation fails
3738
uses: tibdex/github-app-token@3beb63f4bd073e61482598c45c71c1019b59b73a # v2
3839
with:
3940
app_id: ${{ secrets.CAGENT_REVIEWER_APP_ID }}

review-pr/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
uses: docker/cagent-action/.github/workflows/review-pr.yml@latest
3939
with:
4040
auto-review-org: my-org # Only auto-review PRs from this org's members
41-
model: anthropic/claude-haiku-4 # Use a faster/cheaper model
41+
model: anthropic/claude-haiku-4-5 # Use a faster/cheaper model
4242
secrets: inherit
4343
```
4444
@@ -217,7 +217,7 @@ When using `docker/cagent-action/.github/workflows/review-pr.yml`:
217217
| `pr-number` | PR number (auto-detected from event) | - |
218218
| `comment-id` | Comment ID for reactions (auto-detected) | - |
219219
| `additional-prompt` | Additional review guidelines | - |
220-
| `model` | Model override (e.g., `anthropic/claude-haiku-4`) | - |
220+
| `model` | Model override (e.g., `anthropic/claude-haiku-4-5`) | - |
221221
| `cagent-version` | CAgent version | `v1.19.7` |
222222
| `auto-review-org` | Organization for auto-review membership check | `docker` |
223223

@@ -279,7 +279,7 @@ The action uses **Claude Sonnet 4.5** by default. Typical costs per review:
279279
| Large (15+ files) | ~$0.15-0.50 |
280280

281281
Costs depend on diff size, not just file count. To reduce costs:
282-
- Use `model: anthropic/claude-haiku-4` for faster, cheaper reviews
282+
- Use `model: anthropic/claude-haiku-4-5` for faster, cheaper reviews
283283
- Trigger reviews selectively (not on every push)
284284

285285
---
@@ -366,6 +366,6 @@ When you reply to a review comment:
366366

367367
**Reviews are too slow?**
368368
- Large diffs take longer. Consider reviewing smaller PRs
369-
- Use `model: anthropic/claude-haiku-4` for faster (but less thorough) reviews
369+
- Use `model: anthropic/claude-haiku-4-5` for faster (but less thorough) reviews
370370

371371
**Clear the memory cache:** Actions → Caches → Delete `pr-review-memory-*`

review-pr/agents/pr-review-feedback.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
models:
22
haiku:
33
provider: anthropic
4-
model: claude-haiku-4-20250514
4+
model: claude-haiku-4-5
55
max_tokens: 1024
66

77
agents:

review-pr/agents/pr-review.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ models:
55
max_tokens: 8192
66
haiku:
77
provider: anthropic
8-
model: claude-haiku-4
8+
model: claude-haiku-4-5
99
max_tokens: 4096
1010

1111
agents:

review-pr/learn/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ inputs:
3232
required: false
3333
default: "v1.19.7"
3434
model:
35-
description: "Model to use for processing feedback (e.g., anthropic/claude-haiku-4)"
35+
description: "Model to use for processing feedback (e.g., anthropic/claude-haiku-4-5)"
3636
required: false
3737
default: ""
3838

0 commit comments

Comments
 (0)