Merge pull request #1787 from dgageot/daily-fixes-2

Daily fixes for the Nightly issue detector

Author: dgageot

cmd/root/root.go

@@ -320,7 +320,9 @@ func isFirstRun() bool {
 	if err != nil {
 		return false // File already exists or other error, not first run
 	}
-	f.Close()
+	if err := f.Close(); err != nil {
+		slog.Warn("Failed to close first run marker file", "error", err)
+	}
 
 	return true
 }

cmd/root/run.go

@@ -142,11 +142,12 @@ func (f *runExecFlags) runOrExec(ctx context.Context, out *cli.Printer, args []s
 		if err != nil {
 			return fmt.Errorf("failed to create CPU profile: %w", err)
 		}
-		defer pf.Close()
 		if err := pprof.StartCPUProfile(pf); err != nil {
+			pf.Close()
 			return fmt.Errorf("failed to start CPU profile: %w", err)
 		}
 		defer pprof.StopCPUProfile()
+		defer pf.Close()
 		slog.Info("CPU profiling enabled", "file", f.cpuProfile)
 	}