agent/acp: harden file resource link handling#1458
Merged
dgageot merged 2 commits intodocker:mainfrom Jan 23, 2026
Merged
Conversation
Signed-off-by: pnkcaht <samzoovsk19@gmail.com>
dgageot
previously approved these changes
Jan 21, 2026
Signed-off-by: pnkcaht <samzoovsk19@gmail.com>
Contributor
Author
|
I updated a few minor formatting issues to fix the GitHub lint checks, even though the PR had already been approved. @dgageot |
dgageot
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
file://resource links in the ACP agent.filepath.Clean.Related issue
N/A
Description
Previously, file paths from ACP
ResourceLinkblocks were forwarded as-is after stripping thefile://prefix.This change adds lightweight, local validation to avoid sending unsafe paths (absolute paths or
..traversal) to the ACP server.This is defense-in-depth and does not change behavior for valid inputs.
Result