Skip to content

improve message resizing for pending responses#1495

Merged
rumpl merged 1 commit intodocker:mainfrom
krissetto:adjust-bottom-slack-for-pending-spinner
Jan 25, 2026
Merged

improve message resizing for pending responses#1495
rumpl merged 1 commit intodocker:mainfrom
krissetto:adjust-bottom-slack-for-pending-spinner

Conversation

@krissetto
Copy link
Contributor

Avoid breaking the TUI layout when the pendingSpinner appears at the very bottom of the messages area

Screencasts:

before

Screencast.From.2026-01-24.19-41-56.mp4

after

Screencast.From.2026-01-24.19-43-43.mp4

@krissetto krissetto requested a review from a team as a code owner January 24, 2026 18:48
Copy link
Contributor

@Pnkcaht Pnkcaht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a simple suggestion :)

@krissetto
Copy link
Contributor Author

@Pnkcaht btw,there's no need to approve PRs, we have policies in place that allow merging code only when approved maintainers approve the code :)

When anyone else approves a PR, it just sends out un-actionable notifications

@Pnkcaht
Copy link
Contributor

Pnkcaht commented Jan 24, 2026

@krissetto Okay, okay, I didn't know, sorry about that, I just wanted to help :)

dgageot
dgageot previously approved these changes Jan 25, 2026
Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
@krissetto krissetto force-pushed the adjust-bottom-slack-for-pending-spinner branch from 1042d22 to 4fe216a Compare January 25, 2026 20:46
@krissetto
Copy link
Contributor Author

rebased on main

@rumpl rumpl merged commit 9b07059 into docker:main Jan 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants