cli/command/system/runInfo: set negotiated API version when available

The current logic was ignoring (e.g.) `--format=json` formats, and was
only setting the negotiated API version if no format was specified.

While we do want to avoid calling the API if possible, we do already
check if the given template requires a server connection, so let's
move updating the API version to that block.

Signed-off-by: Sebastiaan van Stijn <[email protected]>

Author: thaJeztah

cli/command/system/info.go

@@ -101,11 +101,14 @@ func runInfo(ctx context.Context, cmd *cobra.Command, dockerCli command.Cli, opt
 	var serverConnErr error
 	if needsServerInfo(opts.format, info) {
 		serverConnErr = addServerInfo(ctx, dockerCli, opts.format, &info)
+		if serverConnErr == nil {
+			// Update client API version after it was negotiated.
+			info.ClientInfo.APIVersion = dockerCli.CurrentVersion()
+		}
 	}
 
 	if opts.format == "" {
 		info.UserName = dockerCli.ConfigFile().AuthConfigs[registry.IndexServer].Username
-		info.ClientInfo.APIVersion = dockerCli.CurrentVersion()
 		return errors.Join(prettyPrintInfo(dockerCli, info), serverConnErr)
 	}