Skip to content

Commit 1058b22

Browse files
committed
cli/command: remove errdefs uses
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1 parent eebf682 commit 1058b22

File tree

3 files changed

+27
-10
lines changed

3 files changed

+27
-10
lines changed

cli/command/cli_options.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import (
1111

1212
"github.com/docker/cli/cli/streams"
1313
"github.com/docker/docker/client"
14-
"github.com/docker/docker/errdefs"
1514
"github.com/moby/term"
1615
"github.com/pkg/errors"
1716
)
@@ -178,7 +177,7 @@ func withCustomHeadersFromEnv() client.Opt {
178177
csvReader := csv.NewReader(strings.NewReader(value))
179178
fields, err := csvReader.Read()
180179
if err != nil {
181-
return errdefs.InvalidParameter(errors.Errorf(
180+
return invalidParameter(errors.Errorf(
182181
"failed to parse custom headers from %s environment variable: value must be formatted as comma-separated key=value pairs",
183182
envOverrideHTTPHeaders,
184183
))
@@ -195,7 +194,7 @@ func withCustomHeadersFromEnv() client.Opt {
195194
k = strings.TrimSpace(k)
196195

197196
if k == "" {
198-
return errdefs.InvalidParameter(errors.Errorf(
197+
return invalidParameter(errors.Errorf(
199198
`failed to set custom headers from %s environment variable: value contains a key=value pair with an empty key: '%s'`,
200199
envOverrideHTTPHeaders, kv,
201200
))
@@ -206,7 +205,7 @@ func withCustomHeadersFromEnv() client.Opt {
206205
// from an environment variable with the same name). In the meantime,
207206
// produce an error to prevent users from depending on this.
208207
if !hasValue {
209-
return errdefs.InvalidParameter(errors.Errorf(
208+
return invalidParameter(errors.Errorf(
210209
`failed to set custom headers from %s environment variable: missing "=" in key=value pair: '%s'`,
211210
envOverrideHTTPHeaders, kv,
212211
))

cli/command/defaultcontextstore.go

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import (
77
"github.com/docker/cli/cli/context/docker"
88
"github.com/docker/cli/cli/context/store"
99
cliflags "github.com/docker/cli/cli/flags"
10-
"github.com/docker/docker/errdefs"
1110
"github.com/pkg/errors"
1211
)
1312

@@ -117,15 +116,15 @@ func (s *ContextStoreWithDefault) List() ([]store.Metadata, error) {
117116
// CreateOrUpdate is not allowed for the default context and fails
118117
func (s *ContextStoreWithDefault) CreateOrUpdate(meta store.Metadata) error {
119118
if meta.Name == DefaultContextName {
120-
return errdefs.InvalidParameter(errors.New("default context cannot be created nor updated"))
119+
return invalidParameter(errors.New("default context cannot be created nor updated"))
121120
}
122121
return s.Store.CreateOrUpdate(meta)
123122
}
124123

125124
// Remove is not allowed for the default context and fails
126125
func (s *ContextStoreWithDefault) Remove(name string) error {
127126
if name == DefaultContextName {
128-
return errdefs.InvalidParameter(errors.New("default context cannot be removed"))
127+
return invalidParameter(errors.New("default context cannot be removed"))
129128
}
130129
return s.Store.Remove(name)
131130
}
@@ -145,15 +144,15 @@ func (s *ContextStoreWithDefault) GetMetadata(name string) (store.Metadata, erro
145144
// ResetTLSMaterial is not implemented for default context and fails
146145
func (s *ContextStoreWithDefault) ResetTLSMaterial(name string, data *store.ContextTLSData) error {
147146
if name == DefaultContextName {
148-
return errdefs.InvalidParameter(errors.New("default context cannot be edited"))
147+
return invalidParameter(errors.New("default context cannot be edited"))
149148
}
150149
return s.Store.ResetTLSMaterial(name, data)
151150
}
152151

153152
// ResetEndpointTLSMaterial is not implemented for default context and fails
154153
func (s *ContextStoreWithDefault) ResetEndpointTLSMaterial(contextName string, endpointName string, data *store.EndpointTLSData) error {
155154
if contextName == DefaultContextName {
156-
return errdefs.InvalidParameter(errors.New("default context cannot be edited"))
155+
return invalidParameter(errors.New("default context cannot be edited"))
157156
}
158157
return s.Store.ResetEndpointTLSMaterial(contextName, endpointName, data)
159158
}
@@ -186,7 +185,7 @@ func (s *ContextStoreWithDefault) GetTLSData(contextName, endpointName, fileName
186185
return nil, err
187186
}
188187
if defaultContext.TLS.Endpoints[endpointName].Files[fileName] == nil {
189-
return nil, errdefs.NotFound(errors.Errorf("TLS data for %s/%s/%s does not exist", DefaultContextName, endpointName, fileName))
188+
return nil, notFound(errors.Errorf("TLS data for %s/%s/%s does not exist", DefaultContextName, endpointName, fileName))
190189
}
191190
return defaultContext.TLS.Endpoints[endpointName].Files[fileName], nil
192191
}

cli/command/utils.go

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,3 +151,22 @@ func ValidateOutputPathFileMode(fileMode os.FileMode) error {
151151
}
152152
return nil
153153
}
154+
155+
func invalidParameter(err error) error {
156+
return invalidParameterErr{err}
157+
}
158+
159+
type invalidParameterErr struct{ error }
160+
161+
func (invalidParameterErr) InvalidParameter() {}
162+
163+
func notFound(err error) error {
164+
return notFoundErr{err}
165+
}
166+
167+
type notFoundErr struct{ error }
168+
169+
func (notFoundErr) NotFound() {}
170+
func (e notFoundErr) Unwrap() error {
171+
return e.error
172+
}

0 commit comments

Comments
 (0)