Skip to content

Commit 24bfedf

Browse files
committed
cli/command: deprecate DockerCli.Apply
The Apply method was added when CLI options for constructing the CLI were rewritten into functional options in [cli@7f207f3]. There was no mention in the pull request of this method specifically, and this may have been related to work being done elsewhere on compose-on-kubernetes or the compose-cli plugin that may have needed options to modify the CLI config after it was already initialized. The CLI itself no longer depends on this method since [cli@133279f], and the only known consumer (docker compose) no longer needs it since [cli@2711800] and [cli@048e931]. This patch deprecates the method with the intent to remove it in a future release. [cli@7f207f3]: 7f207f3 [cli@133279f]: 133279f [cli@2711800]: 2711800 [cli@048e931]: 048e931 Signed-off-by: Sebastiaan van Stijn <[email protected]>
1 parent 734328e commit 24bfedf

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

cli/command/cli.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -567,6 +567,8 @@ func (cli *DockerCli) initialize() error {
567567
}
568568

569569
// Apply all the operation on the cli
570+
//
571+
// Deprecated: this method is no longer used and will be removed in the next release if there are no remaining users.
570572
func (cli *DockerCli) Apply(ops ...CLIOption) error {
571573
for _, op := range ops {
572574
if err := op(cli); err != nil {

0 commit comments

Comments
 (0)