Skip to content

Commit 5f4f4f6

Browse files
committed
OTel: implement missing MeterProvider ForceFlush
Signed-off-by: Laura Brehm <[email protected]>
1 parent f07834d commit 5f4f4f6

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

cli/command/telemetry.go

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -186,18 +186,22 @@ func newCLIReader(exp sdkmetric.Exporter) sdkmetric.Reader {
186186
}
187187

188188
func (r *cliReader) Shutdown(ctx context.Context) error {
189-
var rm metricdata.ResourceMetrics
190-
if err := r.Reader.Collect(ctx, &rm); err != nil {
191-
return err
192-
}
193-
194189
// Place a pretty tight constraint on the actual reporting.
195190
// We don't want CLI metrics to prevent the CLI from exiting
196191
// so if there's some kind of issue we need to abort pretty
197192
// quickly.
198193
ctx, cancel := context.WithTimeout(ctx, exportTimeout)
199194
defer cancel()
200195

196+
return r.ForceFlush(ctx)
197+
}
198+
199+
func (r *cliReader) ForceFlush(ctx context.Context) error {
200+
var rm metricdata.ResourceMetrics
201+
if err := r.Reader.Collect(ctx, &rm); err != nil {
202+
return err
203+
}
204+
201205
return r.exporter.Export(ctx, &rm)
202206
}
203207

0 commit comments

Comments
 (0)