Skip to content

Commit 6050e2b

Browse files
authored
Merge pull request #6741 from thaJeztah/fix_err_grammar
login: touch-up error for non-TTY
2 parents 5d22eaa + db76295 commit 6050e2b

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

cli/command/registry/login.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ func loginUser(ctx context.Context, dockerCLI command.Cli, opts loginOptions, de
197197
// will hit this if you attempt docker login from mintty where stdin
198198
// is a pipe, not a character based console.
199199
if (opts.user == "" || opts.password == "") && !dockerCLI.In().IsTerminal() {
200-
return "", errors.New("error: cannot perform an interactive login from a non TTY device")
200+
return "", errors.New("error: cannot perform an interactive login from a non-TTY device")
201201
}
202202

203203
// If we're logging into the index server and the user didn't provide a username or password, use the device flow

cli/command/registry/login_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ func TestRunLogin(t *testing.T) {
127127
input: loginOptions{
128128
serverAddress: "reg1",
129129
},
130-
expectedErr: "error: cannot perform an interactive login from a non TTY device",
130+
expectedErr: "error: cannot perform an interactive login from a non-TTY device",
131131
},
132132
{
133133
doc: "store valid username and password",
@@ -334,19 +334,19 @@ func TestLoginNonInteractive(t *testing.T) {
334334
doc: "error - w/o user w/o pass ",
335335
username: false,
336336
password: false,
337-
expectedErr: "error: cannot perform an interactive login from a non TTY device",
337+
expectedErr: "error: cannot perform an interactive login from a non-TTY device",
338338
},
339339
{
340340
doc: "error - w/ user w/o pass",
341341
username: true,
342342
password: false,
343-
expectedErr: "error: cannot perform an interactive login from a non TTY device",
343+
expectedErr: "error: cannot perform an interactive login from a non-TTY device",
344344
},
345345
{
346346
doc: "error - w/o user w/ pass",
347347
username: false,
348348
password: true,
349-
expectedErr: "error: cannot perform an interactive login from a non TTY device",
349+
expectedErr: "error: cannot perform an interactive login from a non-TTY device",
350350
},
351351
}
352352

@@ -403,13 +403,13 @@ func TestLoginNonInteractive(t *testing.T) {
403403
doc: "error - w/ user w/o pass",
404404
username: true,
405405
password: false,
406-
expectedErr: "error: cannot perform an interactive login from a non TTY device",
406+
expectedErr: "error: cannot perform an interactive login from a non-TTY device",
407407
},
408408
{
409409
doc: "error - w/o user w/ pass",
410410
username: false,
411411
password: true,
412-
expectedErr: "error: cannot perform an interactive login from a non TTY device",
412+
expectedErr: "error: cannot perform an interactive login from a non-TTY device",
413413
},
414414
}
415415

0 commit comments

Comments
 (0)