Merge pull request #6063 from giautm/patch-1

thaJeztah · web-flow · commit 77fbbc38de8d · 2025-05-16T12:03:15.000+02:00
cli/cli: use `len()` to check frontend ports in the `port` command
diff --git a/cli/command/container/port.go b/cli/command/container/port.go
@@ -68,7 +68,7 @@ func runPort(ctx context.Context, dockerCli command.Cli, opts *portOptions) erro
 			return errors.Wrapf(err, "Error: invalid port (%s)", port)
 		}
 		frontends, exists := c.NetworkSettings.Ports[nat.Port(port+"/"+proto)]
-		if !exists || frontends == nil {
+		if !exists || len(frontends) == 0 {
 			return errors.Errorf("Error: No public port '%s' published for %s", opts.port, opts.container)
 		}
 		for _, frontend := range frontends {

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ func runPort(ctx context.Context, dockerCli command.Cli, opts *portOptions) erro`
`68`	`68`	`return errors.Wrapf(err, "Error: invalid port (%s)", port)`
`69`	`69`	`}`
`70`	`70`	`frontends, exists := c.NetworkSettings.Ports[nat.Port(port+"/"+proto)]`
`71`		`- if !exists \|\| frontends == nil {`
	`71`	`+ if !exists \|\| len(frontends) == 0 {`
`72`	`72`	`return errors.Errorf("Error: No public port '%s' published for %s", opts.port, opts.container)`
`73`	`73`	`}`
`74`	`74`	`for _, frontend := range frontends {`