image/tree: Fix table header having escape codes when not tty

vvoland · vvoland · commit e5f46499b303 · 2025-11-04T13:55:30.000+01:00
When stdout is redirected to a non-tty there should be no ANSI escape
codes emitted.

Signed-off-by: Paweł Gronowski &lt;pawel.gronowski@docker.com&gt;
diff --git a/cli/command/image/testdata/list-command-success.filters.golden b/cli/command/image/testdata/list-command-success.filters.golden
@@ -1,2 +1,2 @@
                                                                Info ->  U In Use
-[39m[1mIMAGE[0m   [39m[1mID[0m             [39m[1mDISK USAGE[0m   [39m[1mCONTENT SIZE[0m   [39m[1mEXTRA[0m
+IMAGE   ID             DISK USAGE   CONTENT SIZE   EXTRA
diff --git a/cli/command/image/testdata/list-command-success.format.golden b/cli/command/image/testdata/list-command-success.format.golden
@@ -1,2 +1,2 @@
                                                                Info ->  U In Use
-[39m[1mIMAGE[0m   [39m[1mID[0m             [39m[1mDISK USAGE[0m   [39m[1mCONTENT SIZE[0m   [39m[1mEXTRA[0m
+IMAGE   ID             DISK USAGE   CONTENT SIZE   EXTRA
diff --git a/cli/command/image/testdata/list-command-success.match-name.golden b/cli/command/image/testdata/list-command-success.match-name.golden
@@ -1,2 +1,2 @@
                                                                Info ->  U In Use
-[39m[1mIMAGE[0m   [39m[1mID[0m             [39m[1mDISK USAGE[0m   [39m[1mCONTENT SIZE[0m   [39m[1mEXTRA[0m
+IMAGE   ID             DISK USAGE   CONTENT SIZE   EXTRA
diff --git a/cli/command/image/testdata/list-command-success.simple.golden b/cli/command/image/testdata/list-command-success.simple.golden
@@ -1,2 +1,2 @@
                                                                Info ->  U In Use
-[39m[1mIMAGE[0m   [39m[1mID[0m             [39m[1mDISK USAGE[0m   [39m[1mCONTENT SIZE[0m   [39m[1mEXTRA[0m
+IMAGE   ID             DISK USAGE   CONTENT SIZE   EXTRA
diff --git a/cli/command/image/tree.go b/cli/command/image/tree.go
@@ -241,6 +241,8 @@ func printImageTree(outs command.Streams, view treeView) {
 	topNameColor := out.Color(aec.NewBuilder(aec.BlueF, aec.Bold).ANSI)
 	normalColor := out.Color(tui.ColorSecondary)
 	untaggedColor := out.Color(tui.ColorTertiary)
+	titleColor := out.Color(tui.ColorTitle)
+
 	isTerm := out.IsTerminal()
 
 	out.Println(generateLegend(out, width))
@@ -316,7 +318,7 @@ func printImageTree(outs command.Streams, view treeView) {
 			_, _ = fmt.Fprint(out, strings.Repeat(" ", columnSpacing))
 		}
 
-		_, _ = fmt.Fprint(out, h.Print(tui.ColorTitle, strings.ToUpper(h.Title)))
+		_, _ = fmt.Fprint(out, h.Print(titleColor, strings.ToUpper(h.Title)))
 	}
 	_, _ = fmt.Fprintln(out)
 

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`	`1`	`Info -> U In Use`
`2`		`-[39m[1mIMAGE[0m [39m[1mID[0m [39m[1mDISK USAGE[0m [39m[1mCONTENT SIZE[0m [39m[1mEXTRA[0m`
	`2`	`+IMAGE ID DISK USAGE CONTENT SIZE EXTRA`
Original file line number	Diff line number	Diff line change
`@@ -241,6 +241,8 @@ func printImageTree(outs command.Streams, view treeView) {`
`241`	`241`	`topNameColor := out.Color(aec.NewBuilder(aec.BlueF, aec.Bold).ANSI)`
`242`	`242`	`normalColor := out.Color(tui.ColorSecondary)`
`243`	`243`	`untaggedColor := out.Color(tui.ColorTertiary)`
	`244`	`+ titleColor := out.Color(tui.ColorTitle)`
	`245`	`+`
`244`	`246`	`isTerm := out.IsTerminal()`
`245`	`247`
`246`	`248`	`out.Println(generateLegend(out, width))`
`@@ -316,7 +318,7 @@ func printImageTree(outs command.Streams, view treeView) {`
`316`	`318`	`_, _ = fmt.Fprint(out, strings.Repeat(" ", columnSpacing))`
`317`	`319`	`}`
`318`	`320`
`319`		`- _, _ = fmt.Fprint(out, h.Print(tui.ColorTitle, strings.ToUpper(h.Title)))`
	`321`	`+ _, _ = fmt.Fprint(out, h.Print(titleColor, strings.ToUpper(h.Title)))`
`320`	`322`	`}`
`321`	`323`	`_, _ = fmt.Fprintln(out)`
`322`	`324`