[27.x backport] assorted docs updates #5612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Rogalski <[email protected]> (cherry picked from commit c70b216) Signed-off-by: Sebastiaan van Stijn <[email protected]>
The command to run inside the container is `/etc`. The semicolon is a statement terminator, which ends the command `docker run busybox /etc`, while `echo $?` prints the exit code of that full docker command. Having this mistake could confuse someone who thinks that `/etc; echo $?` is all run inside the container, which wouldn't help the reader understand the exit code of the `docker run` command itself. Signed-off-by: Noah Silas <[email protected]> (cherry picked from commit 0c999fe) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: David Karlsson <[email protected]> (cherry picked from commit 172f340) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 27.x #5612 +/- ##
==========================================
- Coverage 58.65% 58.37% -0.28%
==========================================
Files 345 336 -9
Lines 29053 28781 -272
==========================================
- Hits 17040 16800 -240
+ Misses 11042 11013 -29
+ Partials 971 968 -3 |
robmry
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport:
runexit code 126 description #5591