Skip to content

Commit ddcba90

Browse files
committed
TODO: can we remove the "JSONMessage" wrapping?
Signed-off-by: Sebastiaan van Stijn <[email protected]>
1 parent a9232a8 commit ddcba90

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

pkg/api/dryrunclient.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,7 @@ func (d *DryRunClient) CopyToContainer(ctx context.Context, container, path stri
209209
}
210210

211211
func (d *DryRunClient) ImageBuild(ctx context.Context, reader io.Reader, options build.ImageBuildOptions) (build.ImageBuildResponse, error) {
212+
// TODO(thaJeztah): can we use api/types/jsonstream (or api/pkg/xxxxx) for this?
212213
jsonMessage, err := json.Marshal(&jsonmessage.JSONMessage{
213214
Status: fmt.Sprintf("%[1]sSuccessfully built: dryRunID\n%[1]sSuccessfully tagged: %[2]s\n", DRYRUN_PREFIX, options.Tags[0]),
214215
Progress: &jsonmessage.JSONProgress{},
@@ -257,6 +258,8 @@ func (d *DryRunClient) ImagePush(ctx context.Context, ref string, options image.
257258
if _, _, err := d.resolver.Resolve(ctx, ref); err != nil {
258259
return nil, err
259260
}
261+
262+
// TODO(thaJeztah): can we use api/types/jsonstream (or api/pkg/xxxxx) for this?
260263
jsonMessage, err := json.Marshal(&jsonmessage.JSONMessage{
261264
Status: "Pushed",
262265
Progress: &jsonmessage.JSONProgress{

0 commit comments

Comments
 (0)