Skip to content

Commit f292c4c

Browse files
committed
TODO: can we remove the "JSONMessage" wrapping?
Signed-off-by: Sebastiaan van Stijn <[email protected]>
1 parent 158324a commit f292c4c

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

pkg/api/dryrunclient.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,7 @@ func (d *DryRunClient) CopyToContainer(ctx context.Context, container, path stri
207207
}
208208

209209
func (d *DryRunClient) ImageBuild(ctx context.Context, reader io.Reader, options build.ImageBuildOptions) (build.ImageBuildResponse, error) {
210+
// TODO(thaJeztah): can we use api/types/jsonstream (or api/pkg/xxxxx) for this?
210211
jsonMessage, err := json.Marshal(&jsonmessage.JSONMessage{
211212
Status: fmt.Sprintf("%[1]sSuccessfully built: dryRunID\n%[1]sSuccessfully tagged: %[2]s\n", DRYRUN_PREFIX, options.Tags[0]),
212213
Progress: &jsonmessage.JSONProgress{},
@@ -255,6 +256,8 @@ func (d *DryRunClient) ImagePush(ctx context.Context, ref string, options client
255256
if _, _, err := d.resolver.Resolve(ctx, ref); err != nil {
256257
return nil, err
257258
}
259+
260+
// TODO(thaJeztah): can we use api/types/jsonstream (or api/pkg/xxxxx) for this?
258261
jsonMessage, err := json.Marshal(&jsonmessage.JSONMessage{
259262
Status: "Pushed",
260263
Progress: &jsonmessage.JSONProgress{

0 commit comments

Comments
 (0)