You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix generating pre-release deb/rpm versions when using '.'
The script assumed that pre-release suffixes used the format `-tp<number>`,
`-beta<number>` or `-rc<number>`, however, it's more common (and standard
practice in SemVer) to delimit the `alpha/beta/rc` with a `.`, which allows
SemVer comparing to first sort by pre-release version (`alpha`, `beta`, `rc`),
then by the numeric suffix.
Altogether, we should consider removing this code; using `tp` as a pre-release
*before* `alpha` / `beta` is non-standard (pre-releases are named `alpha`, `beta`,
`rc`, so that they can be sorted alphabetically. Using `tp` violates that assumption,
and adds the complexity of having to add a numeric prefix to make it sort again.
Also see https://www.debian.org/doc/debian-policy/ch-controlfields.html#epochs-should-be-used-sparingly
Before:
./rpm/gen-rpm-ver . 22.06.0-beta0
22.06.0 1.0.beta0 6e7db7f 22.06.0-beta0
./rpm/gen-rpm-ver . 22.06.0-beta.0
22.06.0.beta.0 3 6e7db7f 22.06.0-beta.0
./deb/gen-deb-ver . 22.06.0-beta0
22.06.0~1.0.beta0 22.06.0-beta0
./deb/gen-deb-ver . 22.06.0-beta.0
22.06.0~beta.0~3 22.06.0-beta.0
After:
./rpm/gen-rpm-ver . 22.06.0-beta0
22.06.0 1.0.beta0 3091da7 22.06.0-beta0
./rpm/gen-rpm-ver . 22.06.0-beta.0
22.06.0 1.0.beta.0 3091da7 22.06.0-beta.0
./deb/gen-deb-ver . 22.06.0-beta0
22.06.0~1.0.beta0 22.06.0-beta0
./deb/gen-deb-ver . 22.06.0-beta.0
22.06.0~1.0.beta.0 22.06.0-beta.0
Signed-off-by: Sebastiaan van Stijn <[email protected]>
0 commit comments