Skip to content

Commit 09541b5

Browse files
committed
static: fix location of Windows binary
Not sure why, but looks like the path used `<arch>-daemon` (instead of just `<arch>`). However, it's not consistent either, because `containerutility.exe` is in `<arch>`? When running: make REF=master checkout make REF=master DOCKER_BUILD_PKGS=cross-win static The build failed: mkdir -p build/win/amd64/docker cp /Users/sebastiaan/go/src/github.com/docker/docker-ce-packaging/src/github.com/docker/cli/build/docker-windows-amd64.exe build/win/amd64/docker/docker.exe cp /Users/sebastiaan/go/src/github.com/docker/docker-ce-packaging/src/github.com/docker/docker/bundles/cross/windows/amd64/dockerd-0.0.0-20210629140245-4a6fe51.exe build/win/amd64/docker/dockerd.exe cp: /Users/sebastiaan/go/src/github.com/docker/docker-ce-packaging/src/github.com/docker/docker/bundles/cross/windows/amd64/dockerd-0.0.0-20210629140245-4a6fe51.exe: No such file or directory make[1]: *** [cross-win] Error 1 make: *** [static] Error 2 This is what's in bundles: tree /Users/sebastiaan/go/src/github.com/docker/docker-ce-packaging/src/github.com/docker/docker/bundles/ /Users/sebastiaan/go/src/github.com/docker/docker-ce-packaging/src/github.com/docker/docker/bundles/ └── cross └── windows ├── amd64 │ └── containerutility.exe └── amd64-daemon ├── docker-proxy-0.0.0-20210629140245-4a6fe51.exe ├── docker-proxy-0.0.0-20210629140245-4a6fe51.exe.md5 ├── docker-proxy-0.0.0-20210629140245-4a6fe51.exe.sha256 ├── docker-proxy.exe -> docker-proxy-0.0.0-20210629140245-4a6fe51.exe ├── dockerd-0.0.0-20210629140245-4a6fe51.exe ├── dockerd-0.0.0-20210629140245-4a6fe51.exe.md5 ├── dockerd-0.0.0-20210629140245-4a6fe51.exe.sha256 └── dockerd.exe -> dockerd-0.0.0-20210629140245-4a6fe51.exe Signed-off-by: Sebastiaan van Stijn <[email protected]>
1 parent 7824214 commit 09541b5

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

static/Makefile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,8 @@ cross-win: cross-win-engine cross-win-plugins
6262
cd $(CLI_DIR) && VERSION=$(GEN_STATIC_VER) docker buildx bake --set binary.platform=windows/amd64 binary
6363
mkdir -p build/win/amd64/docker
6464
cp $(CLI_DIR)/build/docker-windows-amd64.exe build/win/amd64/docker/docker.exe
65-
cp $(ENGINE_DIR)/bundles/cross/windows/amd64/dockerd-$(GEN_STATIC_VER).exe build/win/amd64/docker/dockerd.exe
65+
cp $(ENGINE_DIR)/bundles/cross/windows/amd64-daemon/dockerd-$(GEN_STATIC_VER).exe build/win/amd64/docker/dockerd.exe
66+
cp $(ENGINE_DIR)/bundles/cross/windows/amd64-daemon/docker-proxy-$(GEN_STATIC_VER).exe build/win/amd64/docker/dockerd.exe
6667
docker run --rm -v $(CURDIR)/build/win/amd64:/v -w /v alpine sh -c 'apk update&&apk add zip&&zip -r docker-$(GEN_STATIC_VER).zip docker'
6768
$(CHOWN) -R $(shell id -u):$(shell id -g) build
6869

0 commit comments

Comments
 (0)