Skip to content

Commit 59c7a85

Browse files
committed
static: Makefile: add CLI_VERSION
Signed-off-by: Sebastiaan van Stijn <[email protected]>
1 parent 58e329a commit 59c7a85

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

static/Makefile

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@ CLI_DIR = $(realpath $(CURDIR)/../src/github.com/docker/cli)
44
ENGINE_DIR = $(realpath $(CURDIR)/../src/github.com/docker/docker)
55
BUILDX_DIR = $(realpath $(CURDIR)/../src/github.com/docker/buildx)
66

7-
GEN_STATIC_VER=$(shell ./gen-static-ver $(CLI_DIR) $(VERSION))
7+
CLI_VERSION = $(shell ./gen-static-ver $(CLI_DIR) $(VERSION))
8+
GEN_STATIC_VER = $(shell ./gen-static-ver $(CLI_DIR) $(VERSION))
9+
810
HASH_CMD=docker run -v $(CURDIR):/sum -w /sum debian:jessie bash hash_files
911
DIR_TO_HASH:=build/linux
1012
DOCKER_CLI_GOLANG_IMG=golang:$(GO_VERSION)
@@ -77,12 +79,12 @@ buildx:
7779
.PHONY: cross-mac
7880
cross-mac: buildx
7981
# docker cli binaries
80-
cd $(CLI_DIR) && VERSION=$(GEN_STATIC_VER) docker buildx bake --set binary.platform=darwin/amd64,darwin/arm64 binary
82+
cd $(CLI_DIR) && VERSION=$(CLI_VERSION) docker buildx bake --set binary.platform=darwin/amd64,darwin/arm64 binary
8183
dest=$$PWD/build/mac; cd $(CLI_DIR)/build && for platform in *; do \
8284
arch=$$(echo $$platform | cut -d_ -f2); \
8385
mkdir -p $$dest/$$arch/docker; \
8486
cp $$platform/docker-darwin-* $$dest/$$arch/docker/docker && \
85-
tar -C $$dest/$$arch -c -z -f $$dest/$$arch/docker-$(GEN_STATIC_VER).tgz docker; \
87+
tar -C $$dest/$$arch -c -z -f $$dest/$$arch/docker-$(CLI_VERSION).tgz docker; \
8688
$(RM) -r $$dest/$$arch/docker
8789
done
8890

@@ -91,7 +93,7 @@ cross-win: BUILD_DIR=build/win/amd64
9193
cross-win: cross-win-engine
9294
# docker cli binaries
9395
mkdir -p $(BUILD_DIR)/docker
94-
cd $(CLI_DIR) && VERSION=$(GEN_STATIC_VER) docker buildx bake --set binary.platform=windows/amd64 binary
96+
cd $(CLI_DIR) && VERSION=$(CLI_VERSION) docker buildx bake --set binary.platform=windows/amd64 binary
9597
cp $(CLI_DIR)/build/docker-windows-amd64.exe $(BUILD_DIR)/docker/docker.exe
9698

9799
# docker engine binaries
@@ -108,13 +110,13 @@ cross-arm: BUILD_DIR=build/arm
108110
cross-arm: cross-all-cli ## create tgz with linux armhf client only
109111
mkdir -p $(BUILD_DIR)/docker
110112
cp $(CLI_DIR)/build/docker-linux-arm $(BUILD_DIR)/docker/docker
111-
tar -C $(BUILD_DIR) -c -z -f $(BUILD_DIR)/docker-$(GEN_STATIC_VER).tgz docker
113+
tar -C $(BUILD_DIR) -c -z -f $(BUILD_DIR)/docker-$(CLI_VERSION).tgz docker
112114
$(RM) -r $(BUILD_DIR)/docker
113115

114116
.PHONY: static-cli
115117
static-cli:
116118
# TODO(thaJeztah) check if CGO_ENABLED variable is correct here
117-
cd $(CLI_DIR) && VERSION=$(GEN_STATIC_VER) docker buildx bake --set binary.platform=$(TARGETPLATFORM) --set binary.args.CGO_ENABLED=$(CGO_ENABLED) binary
119+
cd $(CLI_DIR) && VERSION=$(CLI_VERSION) docker buildx bake --set binary.platform=$(TARGETPLATFORM) --set binary.args.CGO_ENABLED=$(CGO_ENABLED) binary
118120

119121
.PHONY: static-engine
120122
static-engine:
@@ -126,7 +128,7 @@ static-buildx-plugin:
126128

127129
.PHONY: cross-all-cli
128130
cross-all-cli:
129-
$(MAKE) -C $(CLI_DIR) -f docker.Makefile VERSION=$(GEN_STATIC_VER) cross
131+
$(MAKE) -C $(CLI_DIR) -f docker.Makefile VERSION=$(CLI_VERSION) cross
130132

131133
.PHONY: cross-win-engine
132134
cross-win-engine:

0 commit comments

Comments
 (0)