Skip to content

Commit 167b137

Browse files
committed
vet/lint/fmt before release
Signed-off-by: Jean-Laurent de Morlhon <[email protected]>
1 parent 2a67ef1 commit 167b137

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

Makefile

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@ osxkeychain:
1616
mkdir bin
1717
go build -ldflags -s -o bin/docker-credential-osxkeychain osxkeychain/cmd/main_darwin.go
1818

19-
codesign: osxkeychain
19+
osxcodesign: osxkeychain
2020
$(eval SIGNINGHASH = $(shell security find-identity -v -p codesigning | grep "Developer ID Application: Docker Inc" | cut -d ' ' -f 4))
2121
xcrun -log codesign -s $(SIGNINGHASH) --force --verbose bin/docker-credential-osxkeychain
2222
xcrun codesign --verify --deep --strict --verbose=2 --display bin/docker-credential-osxkeychain
2323

24-
osxrelease: clean test codesign
24+
osxrelease: clean vet_osx lint fmt test osxcodesign
2525
mkdir -p release
2626
@echo "\nPackaging version ${VERSION}\n"
2727
cd bin && tar cvfz ../release/docker-credential-osxkeychain-v$(VERSION)-amd64.tar.gz docker-credential-osxkeychain
@@ -50,8 +50,12 @@ vet_osx:
5050
vet_linux:
5151
go vet ./secretservice
5252

53-
validate: vet
53+
lint:
5454
for p in `go list ./... | grep -v /vendor/`; do \
5555
golint $$p ; \
5656
done
57+
58+
fmt:
5759
gofmt -s -l `ls **/*.go | grep -v vendor`
60+
61+
validate: vet lint fmt

0 commit comments

Comments
 (0)