osxkeychain: use designated domains in tests (RFC2606)

Update domains used in tests to used domains that are designated for this
purpose as described in [RFC2606, section 3][1]

[1]: https://www.rfc-editor.org/rfc/rfc2606.html#section-3

Signed-off-by: Sebastiaan van Stijn <[email protected]>

Author: thaJeztah

osxkeychain/osxkeychain_darwin_test.go

@@ -9,12 +9,12 @@ import (
 
 func TestOSXKeychainHelper(t *testing.T) {
 	creds := &credentials.Credentials{
-		ServerURL: "https://foobar.docker.io:2376/v1",
+		ServerURL: "https://foobar.example.com:2376/v1",
 		Username:  "foobar",
 		Secret:    "foobarbaz",
 	}
 	creds1 := &credentials.Credentials{
-		ServerURL: "https://foobar.docker.io:2376/v2",
+		ServerURL: "https://foobar.example.com:2376/v2",
 		Username:  "foobarbaz",
 		Secret:    "foobar",
 	}
@@ -64,13 +64,13 @@ func TestOSXKeychainHelperRetrieveAliases(t *testing.T) {
 		readURL  string
 	}{
 		// stored with port, retrieved without
-		{"https://foobar.docker.io:2376", "https://foobar.docker.io"},
+		{"https://foobar.example.com:2376", "https://foobar.example.com"},
 
 		// stored as https, retrieved without scheme
-		{"https://foobar.docker.io:2376", "foobar.docker.io"},
+		{"https://foobar.example.com:2376", "foobar.example.com"},
 
 		// stored with path, retrieved without
-		{"https://foobar.docker.io:1234/one/two", "https://foobar.docker.io:1234"},
+		{"https://foobar.example.com:1234/one/two", "https://foobar.example.com:1234"},
 	}
 
 	helper := Osxkeychain{}
@@ -106,22 +106,24 @@ func TestOSXKeychainHelperRetrieveStrict(t *testing.T) {
 		readURL  string
 	}{
 		// stored as https, retrieved using http
-		{"https://foobar.docker.io:2376", "http://foobar.docker.io:2376"},
+		{"https://foobar.example.com:2376", "http://foobar.example.com:2376"},
 
 		// stored as http, retrieved using https
-		{"http://foobar.docker.io:2376", "https://foobar.docker.io:2376"},
+		{"http://foobar.example.com:2376", "https://foobar.example.com:2376"},
 
 		// same: stored as http, retrieved without a scheme specified (hence, using the default https://)
-		{"http://foobar.docker.io", "foobar.docker.io:5678"},
+		{"http://foobar.example.com", "foobar.example.com:5678"},
 
 		// non-matching ports
-		{"https://foobar.docker.io:1234", "https://foobar.docker.io:5678"},
+		{"https://foobar.example.com:1234", "https://foobar.example.com:5678"},
 
-		// non-matching ports TODO is this desired behavior? The other way round does work
-		//{"https://foobar.docker.io", "https://foobar.docker.io:5678"},
+		// non-matching ports
+		//
+		// TODO: is this desired behavior? The other way round does work
+		// {"https://foobar.example.com", "https://foobar.example.com:5678"},
 
 		// non-matching paths
-		{"https://foobar.docker.io:1234/one/two", "https://foobar.docker.io:1234/five/six"},
+		{"https://foobar.example.com:1234/one/two", "https://foobar.example.com:1234/five/six"},
 	}
 
 	helper := Osxkeychain{}
@@ -155,14 +157,14 @@ func TestOSXKeychainHelperStoreRetrieve(t *testing.T) {
 	tests := []struct {
 		url string
 	}{
-		{url: "foobar.docker.io"},
-		{url: "foobar.docker.io:2376"},
-		{url: "//foobar.docker.io:2376"},
-		{url: "https://foobar.docker.io:2376"},
-		{url: "http://foobar.docker.io:2376"},
-		{url: "https://foobar.docker.io:2376/some/path"},
-		{url: "https://foobar.docker.io:2376/some/other/path"},
-		{url: "https://foobar.docker.io:2376/some/other/path?foo=bar"},
+		{url: "foobar.example.com"},
+		{url: "foobar.example.com:2376"},
+		{url: "//foobar.example.com:2376"},
+		{url: "https://foobar.example.com:2376"},
+		{url: "http://foobar.example.com:2376"},
+		{url: "https://foobar.example.com:2376/some/path"},
+		{url: "https://foobar.example.com:2376/some/other/path"},
+		{url: "https://foobar.example.com:2376/some/other/path?foo=bar"},
 	}
 
 	helper := Osxkeychain{}