Style fixes - incorporates PR feedback

ekcasey · Danny Joyce · commit 77e30bd9dd9f · 2019-04-29T10:51:04.000-04:00
Signed-off-by: Emily Casey &lt;ecasey@pivotal.io&gt;
Signed-off-by: Danny Joyce &lt;djoyce@pivotal.io&gt;
diff --git a/wincred/wincred_windows.go b/wincred/wincred_windows.go
@@ -72,12 +72,11 @@ func getTarget(serverURL string) (string, error) {
 		return "", err
 	}
 
-	targets := make([]string, 0)
+	var targets []string
 	for i := range creds {
 		attrs := creds[i].Attributes
 		for _, attr := range attrs {
-			if strings.Compare(attr.Keyword, "label") == 0 &&
-				bytes.Compare(attr.Value, []byte(credentials.CredsLabel)) == 0 {
+			if attr.Keyword == "label" && bytes.Equal(attr.Value, []byte(credentials.CredsLabel)) {
 				targets = append(targets, creds[i].TargetName)
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -72,12 +72,11 @@ func getTarget(serverURL string) (string, error) {`
`72`	`72`	`return "", err`
`73`	`73`	`}`
`74`	`74`
`75`		`- targets := make([]string, 0)`
	`75`	`+ var targets []string`
`76`	`76`	`for i := range creds {`
`77`	`77`	`attrs := creds[i].Attributes`
`78`	`78`	`for _, attr := range attrs {`
`79`		`- if strings.Compare(attr.Keyword, "label") == 0 &&`
`80`		`- bytes.Compare(attr.Value, []byte(credentials.CredsLabel)) == 0 {`
	`79`	`+ if attr.Keyword == "label" && bytes.Equal(attr.Value, []byte(credentials.CredsLabel)) {`
`81`	`80`	`targets = append(targets, creds[i].TargetName)`
`82`	`81`	`}`
`83`	`82`	`}`