Skip to content

Commit 7e9571d

Browse files
committed
Makefile/test: Fix failure not being propagated
Running in subshell doesn't automatically propagate its exit code to the parent shell (even with `set -e`). This made the `make test` command NOT exit with a non-zero exit code if the test actually failed. Also drop `tail` call because it's actually better to have the full trace. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
1 parent 66ec315 commit 7e9571d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ test: $(foreach channel,$(CHANNELS),build/$(channel)/install.sh)
4242
-e VERSION \
4343
-e CHANNEL \
4444
$(TEST_IMAGE) \
45-
sh $$file) | tail -n 30; \
45+
sh $$file) || exit $$?; \
4646
done
4747

4848
AWS?=docker run \

0 commit comments

Comments
 (0)