Merge pull request #138 from docker/volume-name-compose-completions

Support volume names in Compose completions

Author: rcjsuen

internal/compose/completion.go

@@ -180,6 +180,7 @@ func dependencyCompletionItems(file *ast.File, path []*ast.MappingValueNode, par
 	dependency := map[string]string{
 		"depends_on": "services",
 		"networks":   "networks",
+		"volumes":    "volumes",
 	}
 	for key, value := range dependency {
 		if len(path) == 3 && path[2].Key.GetToken().Value == key {

internal/compose/completion_test.go

@@ -2026,6 +2026,95 @@ services:
     networks:
       
 networks:
+  test2:
+    image: alpine`,
+			line:      5,
+			character: 6,
+			list: &protocol.CompletionList{
+				Items: []protocol.CompletionItem{
+					{
+						Label:    "test2",
+						TextEdit: textEdit("test2", 5, 6, 0),
+					},
+				},
+			},
+		},
+		{
+			name: "volumes array items",
+			content: `
+services:
+  test:
+    image: alpine
+    volumes:
+      - 
+volumes:
+  test2:
+    image: alpine`,
+			line:      5,
+			character: 8,
+			list: &protocol.CompletionList{
+				Items: []protocol.CompletionItem{
+					{
+						Label:    "test2",
+						TextEdit: textEdit("test2", 5, 8, 0),
+					},
+				},
+			},
+		},
+		{
+			name: "volumes array items across two files",
+			content: `
+---
+services:
+  test:
+    image: alpine
+    volumes:
+      - 
+---
+volumes:
+  test2:`,
+			line:      6,
+			character: 8,
+			list: &protocol.CompletionList{
+				Items: []protocol.CompletionItem{
+					{
+						Label:    "test2",
+						TextEdit: textEdit("test2", 6, 8, 0),
+					},
+				},
+			},
+		},
+		{
+			name: "volumes array items",
+			content: `
+services:
+  test:
+    image: alpine
+    volumes:
+      - t
+volumes:
+  test2:
+    image: alpine`,
+			line:      5,
+			character: 9,
+			list: &protocol.CompletionList{
+				Items: []protocol.CompletionItem{
+					{
+						Label:    "test2",
+						TextEdit: textEdit("test2", 5, 9, 1),
+					},
+				},
+			},
+		},
+		{
+			name: "volumes service object",
+			content: `
+services:
+  test:
+    image: alpine
+    volumes:
+      
+volumes:
   test2:
     image: alpine`,
 			line:      5,