Merge pull request #494 from docker/compose-links-in-single-quotes-fix

rcjsuen · web-flow · commit 8da6e44c2e08 · 2025-11-21T04:40:03.000Z
Handle single quotes correctly for document links in Compose
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,8 @@ All notable changes to the Docker Language Server will be documented in this fil
 - Compose
   - textDocument/completion
     - check the prefix string before trying to use it for looking up image tags ([#486](https://github.com/docker/docker-language-server/issues/486))
+  - textDocument/documentLink
+    - correct the link range if the string is wrapped in single quotes ([#487](https://github.com/docker/docker-language-server/issues/487))
 - Bake
   - fix parsing error caused by referencing a variable with no value ([#490](https://github.com/docker/docker-language-server/issues/490))
 
diff --git a/internal/compose/documentLink.go b/internal/compose/documentLink.go
@@ -18,7 +18,7 @@ import (
 
 func createRange(t *token.Token, length int) protocol.Range {
 	offset := 0
-	if t.Type == token.DoubleQuoteType {
+	if t.Type == token.DoubleQuoteType || t.Type == token.SingleQuoteType {
 		offset = 1
 	}
 	return protocol.Range{
diff --git a/internal/compose/documentLink_test.go b/internal/compose/documentLink_test.go

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ import (`
`18`	`18`
`19`	`19`	`func createRange(t *token.Token, length int) protocol.Range {`
`20`	`20`	`offset := 0`
`21`		`- if t.Type == token.DoubleQuoteType {`
	`21`	`+ if t.Type == token.DoubleQuoteType \|\| t.Type == token.SingleQuoteType {`
`22`	`22`	`offset = 1`
`23`	`23`	`}`
`24`	`24`	`return protocol.Range{`