Skip to content

Commit 380914a

Browse files
cylishin-
authored andcommitted
If we're pinning exact versions of things for requirements.txt, pin
all dependencies of dependencies as well so we can get a consistent build. Signed-off-by: cyli <[email protected]>
1 parent 0494c4f commit 380914a

File tree

2 files changed

+18
-8
lines changed

2 files changed

+18
-8
lines changed

requirements.txt

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,16 @@
1-
requests[security]==2.11.1
2-
six>=1.4.0
3-
websocket-client==0.32.0
4-
backports.ssl_match_hostname>=3.5 ; python_version < '3.5'
5-
ipaddress==1.0.16 ; python_version < '3.3'
1+
appdirs==1.4.3
2+
asn1crypto==0.22.0
3+
backports.ssl-match-hostname==3.5.0.1
4+
cffi==1.10.0
5+
cryptography==1.9
66
docker-pycreds==0.2.1
7+
enum34==1.1.6
8+
idna==2.5
9+
ipaddress==1.0.18
10+
packaging==16.8
11+
pycparser==2.17
12+
pyOpenSSL==17.0.0
13+
pyparsing==2.2.0
14+
requests==2.14.2
15+
six==1.10.0
16+
websocket-client==0.40.0

setup.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,10 @@
3636
# ServerAltname: https://pypi.python.org/pypi/backports.ssl_match_hostname
3737
':python_version < "3.3"': 'ipaddress >= 1.0.16',
3838

39-
# If using docker-py over TLS, highly recommend this option is pip-installed
40-
# or pinned.
39+
# If using docker-py over TLS, highly recommend this option is
40+
# pip-installed or pinned.
4141

42-
# TODO: if pip installign both "requests" and "requests[security]", the
42+
# TODO: if pip installing both "requests" and "requests[security]", the
4343
# extra package from the "security" option are not installed (see
4444
# https://github.com/pypa/pip/issues/4391). Once that's fixed, instead of
4545
# installing the extra dependencies, install the following instead:

0 commit comments

Comments
 (0)