Skip to content

Commit 41c2167

Browse files
committed
Explicitly test NetworkMode logic in create_host_config
Signed-off-by: Aanand Prasad <[email protected]>
1 parent d9a149f commit 41c2167

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

tests/utils_test.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -144,11 +144,13 @@ def test_convert_filters(self):
144144
for filters, expected in tests:
145145
self.assertEqual(convert_filters(filters), expected)
146146

147-
def test_create_empty_host_config(self):
148-
empty_config = create_host_config(
149-
network_mode='', version=DEFAULT_DOCKER_API_VERSION
150-
)
151-
self.assertEqual(empty_config, {})
147+
def test_create_host_config_no_options(self):
148+
config = create_host_config(version='1.19')
149+
self.assertFalse('NetworkMode' in config)
150+
151+
def test_create_host_config_no_options_newer_api_version(self):
152+
config = create_host_config(version='1.20')
153+
self.assertEqual(config['NetworkMode'], 'default')
152154

153155
def test_create_host_config_dict_ulimit(self):
154156
ulimit_dct = {'name': 'nofile', 'soft': 8096}

0 commit comments

Comments
 (0)