Skip to content

Commit 5344e11

Browse files
committed
Fix typo in create_network
Signed-off-by: Joffrey F <[email protected]>
1 parent 82634fe commit 5344e11

File tree

2 files changed

+16
-4
lines changed

2 files changed

+16
-4
lines changed

docker/api/network.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def networks(self, names=None, ids=None):
3838
@minimum_version('1.21')
3939
def create_network(self, name, driver=None, options=None, ipam=None,
4040
check_duplicate=None, internal=False, labels=None,
41-
enable_ipv6=False, attachable=None):
41+
enable_ipv6=False, attachable=None, scope=None):
4242
"""
4343
Create a network. Similar to the ``docker network create``.
4444
@@ -119,10 +119,11 @@ def create_network(self, name, driver=None, options=None, ipam=None,
119119
'supported in API version < 1.22')
120120
data['Internal'] = True
121121

122-
if attachable is not None
122+
if attachable is not None:
123123
if version_lt(self._version, '1.24'):
124-
raise InvalidVersion('Attachable is not '
125-
'supported in API version < 1.24')
124+
raise InvalidVersion(
125+
'attachable is not supported in API version < 1.24'
126+
)
126127
data['Attachable'] = attachable
127128

128129
url = self._url("/networks/create")

tests/integration/api_network_test.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@
77

88

99
class TestNetworks(BaseAPIIntegrationTest):
10+
def tearDown(self):
11+
super(TestNetworks, self).tearDown()
12+
self.client.leave_swarm(force=True)
13+
1014
def create_network(self, *args, **kwargs):
1115
net_name = random_name()
1216
net_id = self.client.create_network(net_name, *args, **kwargs)['Id']
@@ -434,3 +438,10 @@ def test_create_network_ipv6_enabled(self):
434438
_, net_id = self.create_network(enable_ipv6=True)
435439
net = self.client.inspect_network(net_id)
436440
assert net['EnableIPv6'] is True
441+
442+
@requires_api_version('1.24')
443+
def test_create_network_attachable(self):
444+
assert self.client.init_swarm('eth0')
445+
_, net_id = self.create_network(driver='overlay', attachable=True)
446+
net = self.client.inspect_network(net_id)
447+
assert net['Attachable'] is True

0 commit comments

Comments
 (0)