Skip to content

Commit 5a1c7ed

Browse files
committed
Merge pull request #820 from docker/819-volumes-create
Update `Client.create_volume` to use new endpoint
2 parents 4552e78 + 0258c6e commit 5a1c7ed

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

docker/api/volume.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ def volumes(self, filters=None):
1212

1313
@utils.minimum_version('1.21')
1414
def create_volume(self, name, driver=None, driver_opts=None):
15-
url = self._url('/volumes')
15+
url = self._url('/volumes/create')
1616
if driver_opts is not None and not isinstance(driver_opts, dict):
1717
raise TypeError('driver_opts must be a dictionary')
1818

tests/fake_api.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -529,7 +529,7 @@ def fake_remove_volume():
529529
get_fake_events,
530530
('{1}/{0}/volumes'.format(CURRENT_VERSION, prefix), 'GET'):
531531
get_fake_volume_list,
532-
('{1}/{0}/volumes'.format(CURRENT_VERSION, prefix), 'POST'):
532+
('{1}/{0}/volumes/create'.format(CURRENT_VERSION, prefix), 'POST'):
533533
get_fake_volume,
534534
('{1}/{0}/volumes/{2}'.format(
535535
CURRENT_VERSION, prefix, FAKE_VOLUME_NAME

tests/test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2208,7 +2208,7 @@ def test_create_volume(self):
22082208
args = fake_request.call_args
22092209

22102210
self.assertEqual(args[0][0], 'POST')
2211-
self.assertEqual(args[0][1], url_prefix + 'volumes')
2211+
self.assertEqual(args[0][1], url_prefix + 'volumes/create')
22122212
self.assertEqual(json.loads(args[1]['data']), {'Name': name})
22132213

22142214
@base.requires_api_version('1.21')
@@ -2219,7 +2219,7 @@ def test_create_volume_with_driver(self):
22192219
args = fake_request.call_args
22202220

22212221
self.assertEqual(args[0][0], 'POST')
2222-
self.assertEqual(args[0][1], url_prefix + 'volumes')
2222+
self.assertEqual(args[0][1], url_prefix + 'volumes/create')
22232223
data = json.loads(args[1]['data'])
22242224
self.assertIn('Driver', data)
22252225
self.assertEqual(data['Driver'], driver_name)

0 commit comments

Comments
 (0)