Skip to content

Commit 5fb7811

Browse files
committed
Use experimental engine for testing in Jenkins/Makefile
Signed-off-by: Joffrey F <[email protected]>
1 parent 54244d0 commit 5fb7811

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

Jenkinsfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def runTests = { Map settings ->
6363
def testContainerName = "dpy-tests-\$BUILD_NUMBER-\$EXECUTOR_NUMBER-${pythonVersion}-${dockerVersion}"
6464
try {
6565
sh """docker run -d --name ${dindContainerName} -v /tmp --privileged \\
66-
dockerswarm/dind:${dockerVersion} docker daemon -H tcp://0.0.0.0:2375
66+
dockerswarm/dind:${dockerVersion} docker daemon -H tcp://0.0.0.0:2375 --experimental
6767
"""
6868
sh """docker run \\
6969
--name ${testContainerName} --volumes-from ${dindContainerName} \\

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ integration-test-py3: build-py3
4545
integration-dind: build build-py3
4646
docker rm -vf dpy-dind || :
4747
docker run -d --name dpy-dind --privileged dockerswarm/dind:1.13.1 docker daemon\
48-
-H tcp://0.0.0.0:2375
48+
-H tcp://0.0.0.0:2375 --experimental
4949
docker run --rm --env="DOCKER_HOST=tcp://docker:2375" --env="DOCKER_TEST_API_VERSION=1.26"\
5050
--link=dpy-dind:docker docker-sdk-python py.test tests/integration
5151
docker run --rm --env="DOCKER_HOST=tcp://docker:2375" --env="DOCKER_TEST_API_VERSION=1.26"\
@@ -59,7 +59,7 @@ integration-dind-ssl: build-dind-certs build build-py3
5959
--env="DOCKER_CERT_PATH=/certs" --volumes-from dpy-dind-certs --name dpy-dind-ssl\
6060
-v /tmp --privileged dockerswarm/dind:1.13.1 docker daemon --tlsverify\
6161
--tlscacert=/certs/ca.pem --tlscert=/certs/server-cert.pem\
62-
--tlskey=/certs/server-key.pem -H tcp://0.0.0.0:2375
62+
--tlskey=/certs/server-key.pem -H tcp://0.0.0.0:2375 --experimental
6363
docker run --rm --volumes-from dpy-dind-ssl --env="DOCKER_HOST=tcp://docker:2375"\
6464
--env="DOCKER_TLS_VERIFY=1" --env="DOCKER_CERT_PATH=/certs" --env="DOCKER_TEST_API_VERSION=1.26"\
6565
--link=dpy-dind-ssl:docker docker-sdk-python py.test tests/integration

tests/integration/api_service_test.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import time
55

66
import docker
7+
import six
78

89
from ..helpers import (
910
force_leave_swarm, requires_api_version, requires_experimental
@@ -108,6 +109,8 @@ def test_service_logs(self):
108109
assert self.get_service_container(name, include_stopped=True)
109110
logs = self.client.service_logs(svc_id, stdout=True, is_tty=False)
110111
log_line = next(logs)
112+
if six.PY3:
113+
log_line = log_line.decode('utf-8')
111114
assert 'hello\n' in log_line
112115
assert 'com.docker.swarm.service.id={}'.format(
113116
svc_id['ID']

0 commit comments

Comments
 (0)