Skip to content

Commit 65ba043

Browse files
committed
Update test engine versions in Jenkinsfile
Signed-off-by: Joffrey F <[email protected]> Conflicts: Jenkinsfile
1 parent 3bad051 commit 65ba043

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

Jenkinsfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ def imageNamePy2
55
def imageNamePy3
66
def images = [:]
77

8-
def dockerVersions = ["1.13.1", "17.04.0-ce", "17.05.0-ce", "17.06.0-ce", "17.07.0-ce-rc3"]
8+
def dockerVersions = ["17.06.2-ce", "17.09.0-ce", "17.10.0-ce"]
99

1010
def buildImage = { name, buildargs, pyTag ->
1111
img = docker.image(name)
@@ -33,7 +33,7 @@ def buildImages = { ->
3333
}
3434

3535
def getAPIVersion = { engineVersion ->
36-
def versionMap = ['1.13.': '1.26', '17.04': '1.27', '17.05': '1.29', '17.06': '1.30', '17.07': '1.31']
36+
def versionMap = ['17.06': '1.30', '17.09': '1.32', '17.10': '1.33']
3737
return versionMap[engineVersion.substring(0, 5)]
3838
}
3939

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ integration-test: build
4141
integration-test-py3: build-py3
4242
docker run -t --rm -v /var/run/docker.sock:/var/run/docker.sock docker-sdk-python3 py.test tests/integration/${file}
4343

44-
TEST_API_VERSION ?= 1.30
45-
TEST_ENGINE_VERSION ?= 17.06.0-ce
44+
TEST_API_VERSION ?= 1.33
45+
TEST_ENGINE_VERSION ?= 17.10.0-ce
4646

4747
.PHONY: integration-dind
4848
integration-dind: build build-py3

tests/integration/api_build_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ def test_build_container_with_target(self):
210210
pass
211211

212212
info = self.client.inspect_image('build1')
213-
self.assertEqual(info['Config']['OnBuild'], [])
213+
assert not info['Config']['OnBuild']
214214

215215
@requires_api_version('1.25')
216216
def test_build_with_network_mode(self):

0 commit comments

Comments
 (0)