Skip to content

Commit 727080b

Browse files
author
aiordache
committed
set version to 'auto' to avoid breaking on old engine versions
Signed-off-by: aiordache <[email protected]>
1 parent 0dfae33 commit 727080b

File tree

1 file changed

+21
-23
lines changed

1 file changed

+21
-23
lines changed

docker/api/client.py

Lines changed: 21 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,19 @@
77
import six
88
import websocket
99

10+
from .. import auth
11+
from ..constants import (DEFAULT_DOCKER_API_VERSION, DEFAULT_NUM_POOLS,
12+
DEFAULT_NUM_POOLS_SSH, DEFAULT_TIMEOUT_SECONDS,
13+
DEFAULT_USER_AGENT, IS_WINDOWS_PLATFORM,
14+
MINIMUM_DOCKER_API_VERSION, STREAM_HEADER_SIZE_BYTES)
15+
from ..errors import (DockerException, InvalidVersion, TLSParameterError,
16+
create_api_error_from_http_exception)
17+
from ..tls import TLSConfig
18+
from ..transport import SSLHTTPAdapter, UnixHTTPAdapter
19+
from ..utils import check_resource, config, update_headers, utils
20+
from ..utils.json_stream import json_stream
21+
from ..utils.proxy import ProxyConfig
22+
from ..utils.socket import consume_socket_output, demux_adaptor, frames_iter
1023
from .build import BuildApiMixin
1124
from .config import ConfigApiMixin
1225
from .container import ContainerApiMixin
@@ -19,22 +32,7 @@
1932
from .service import ServiceApiMixin
2033
from .swarm import SwarmApiMixin
2134
from .volume import VolumeApiMixin
22-
from .. import auth
23-
from ..constants import (
24-
DEFAULT_TIMEOUT_SECONDS, DEFAULT_USER_AGENT, IS_WINDOWS_PLATFORM,
25-
DEFAULT_DOCKER_API_VERSION, MINIMUM_DOCKER_API_VERSION,
26-
STREAM_HEADER_SIZE_BYTES, DEFAULT_NUM_POOLS_SSH, DEFAULT_NUM_POOLS
27-
)
28-
from ..errors import (
29-
DockerException, InvalidVersion, TLSParameterError,
30-
create_api_error_from_http_exception
31-
)
32-
from ..tls import TLSConfig
33-
from ..transport import SSLHTTPAdapter, UnixHTTPAdapter
34-
from ..utils import utils, check_resource, update_headers, config
35-
from ..utils.socket import frames_iter, consume_socket_output, demux_adaptor
36-
from ..utils.json_stream import json_stream
37-
from ..utils.proxy import ProxyConfig
35+
3836
try:
3937
from ..transport import NpipeHTTPAdapter
4038
except ImportError:
@@ -183,14 +181,14 @@ def __init__(self, base_url=None, version=None,
183181
self.base_url = base_url
184182

185183
# version detection needs to be after unix adapter mounting
186-
if version is None:
187-
self._version = DEFAULT_DOCKER_API_VERSION
188-
elif isinstance(version, six.string_types):
189-
if version.lower() == 'auto':
190-
self._version = self._retrieve_server_version()
191-
else:
192-
self._version = version
184+
if version is None or (
185+
isinstance(version, six.string_types) and
186+
version.lower()) == 'auto':
187+
self._version = self._retrieve_server_version()
193188
else:
189+
self._version = version
190+
191+
if not isinstance(self._version, six.string_types):
194192
raise DockerException(
195193
'Version parameter must be a string or None. Found {0}'.format(
196194
type(version).__name__

0 commit comments

Comments
 (0)