Skip to content

Commit 772262f

Browse files
committed
Merge pull request #645 from docker/update-websocket-client-dep
Update websocket client dependency
2 parents f40e034 + ed94c0d commit 772262f

File tree

5 files changed

+5
-30
lines changed

5 files changed

+5
-30
lines changed

docker/client.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323
import requests
2424
import requests.exceptions
2525
import six
26+
import websocket
27+
2628

2729
from . import constants
2830
from . import errors
@@ -33,10 +35,6 @@
3335
from .tls import TLSConfig
3436

3537

36-
if not six.PY3:
37-
import websocket
38-
39-
4038
class Client(requests.Session):
4139
def __init__(self, base_url=None, version=None,
4240
timeout=constants.DEFAULT_TIMEOUT_SECONDS, tls=False):
@@ -154,9 +152,6 @@ def _attach_params(self, override=None):
154152

155153
@check_resource
156154
def _attach_websocket(self, container, params=None):
157-
if six.PY3:
158-
raise NotImplementedError("This method is not currently supported "
159-
"under python 3")
160155
url = self._url("/containers/{0}/attach/ws".format(container))
161156
req = requests.Request("POST", url, params=self._attach_params(params))
162157
full_url = req.prepare().url

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
requests==2.5.3
22
six>=1.3.0
3-
websocket-client==0.11.0
3+
websocket-client==0.32.0

requirements3.txt

Lines changed: 0 additions & 2 deletions
This file was deleted.

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
]
1313

1414
if sys.version_info[0] < 3:
15-
requirements.append('websocket-client >= 0.11.0')
15+
requirements.append('websocket-client >= 0.32.0')
1616

1717
exec(open('docker/version.py').read())
1818

tox.ini

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -2,24 +2,6 @@
22
envlist = py26, py27, py32, py33, py34, flake8
33
skipsdist=True
44

5-
[testenv:py26]
6-
usedevelop=True
7-
commands =
8-
{envbindir}/coverage run -p tests/test.py
9-
{envbindir}/coverage run -p tests/utils_test.py
10-
deps =
11-
-r{toxinidir}/requirements.txt
12-
-r{toxinidir}/test-requirements.txt
13-
14-
[testenv:py27]
15-
usedevelop=True
16-
commands =
17-
{envbindir}/coverage run -p tests/test.py
18-
{envbindir}/coverage run -p tests/utils_test.py
19-
deps =
20-
-r{toxinidir}/requirements.txt
21-
-r{toxinidir}/test-requirements.txt
22-
235
[testenv]
246
usedevelop=True
257
commands =
@@ -29,8 +11,8 @@ commands =
2911
{envbindir}/coverage report
3012
{envbindir}/coverage html
3113
deps =
32-
-r{toxinidir}/requirements3.txt
3314
-r{toxinidir}/test-requirements.txt
15+
-r{toxinidir}/requirements.txt
3416

3517
[testenv:flake8]
3618
commands = flake8 docker tests

0 commit comments

Comments
 (0)