Skip to content

Commit 881e24c

Browse files
committed
Merge pull request #839 from docker/bump_api_version_121
Bump default API version to 1.21
2 parents 47ab89e + 4f1304c commit 881e24c

File tree

3 files changed

+20
-17
lines changed

3 files changed

+20
-17
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,14 @@ integration-test-py3: build-py3
2929
docker run -v /var/run/docker.sock:/var/run/docker.sock docker-py3 py.test tests/integration
3030

3131
integration-dind: build build-py3
32-
docker run -d --name dpy-dind --env="DOCKER_HOST=tcp://localhost:2375" --privileged dockerswarm/dind:1.8.1 docker -d -H tcp://0.0.0.0:2375
32+
docker run -d --name dpy-dind --env="DOCKER_HOST=tcp://localhost:2375" --privileged dockerswarm/dind:1.9.0 docker -d -H tcp://0.0.0.0:2375
3333
docker run --env="DOCKER_HOST=tcp://docker:2375" --link=dpy-dind:docker docker-py py.test tests/integration
3434
docker run --env="DOCKER_HOST=tcp://docker:2375" --link=dpy-dind:docker docker-py3 py.test tests/integration
3535
docker rm -vf dpy-dind
3636

3737
integration-dind-ssl: build-dind-certs build build-py3
3838
docker run -d --name dpy-dind-certs dpy-dind-certs
39-
docker run -d --env="DOCKER_HOST=tcp://localhost:2375" --env="DOCKER_TLS_VERIFY=1" --env="DOCKER_CERT_PATH=/certs" --volumes-from dpy-dind-certs --name dpy-dind-ssl -v /tmp --privileged dockerswarm/dind:1.8.1 docker daemon --tlsverify --tlscacert=/certs/ca.pem --tlscert=/certs/server-cert.pem --tlskey=/certs/server-key.pem -H tcp://0.0.0.0:2375
39+
docker run -d --env="DOCKER_HOST=tcp://localhost:2375" --env="DOCKER_TLS_VERIFY=1" --env="DOCKER_CERT_PATH=/certs" --volumes-from dpy-dind-certs --name dpy-dind-ssl -v /tmp --privileged dockerswarm/dind:1.9.0 docker daemon --tlsverify --tlscacert=/certs/ca.pem --tlscert=/certs/server-cert.pem --tlskey=/certs/server-key.pem -H tcp://0.0.0.0:2375
4040
docker run --volumes-from dpy-dind-ssl --env="DOCKER_HOST=tcp://docker:2375" --env="DOCKER_TLS_VERIFY=1" --env="DOCKER_CERT_PATH=/certs" --link=dpy-dind-ssl:docker docker-py py.test tests/integration_test.py
4141
docker run --volumes-from dpy-dind-ssl --env="DOCKER_HOST=tcp://docker:2375" --env="DOCKER_TLS_VERIFY=1" --env="DOCKER_CERT_PATH=/certs" --link=dpy-dind-ssl:docker docker-py3 py.test tests/integration_test.py
4242
docker rm -vf dpy-dind-ssl dpy-dind-certs

docker/constants.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
DEFAULT_DOCKER_API_VERSION = '1.20'
1+
DEFAULT_DOCKER_API_VERSION = '1.21'
22
DEFAULT_TIMEOUT_SECONDS = 60
33
STREAM_HEADER_SIZE_BYTES = 8
44
CONTAINER_LIMITS_KEYS = [

tests/integration/network_test.py

Lines changed: 17 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
@requires_api_version('1.21')
1111
class TestNetworks(api_test.BaseTestCase):
1212
def create_network(self, *args, **kwargs):
13-
net_name = 'dockerpy{}'.format(random.getrandbits(24))[:14]
14-
net_id = self.client.create_network(net_name, *args, **kwargs)['id']
13+
net_name = u'dockerpy{}'.format(random.getrandbits(24))[:14]
14+
net_id = self.client.create_network(net_name, *args, **kwargs)['Id']
1515
self.tmp_networks.append(net_id)
1616
return (net_name, net_id)
1717

@@ -23,23 +23,26 @@ def test_list_networks(self):
2323

2424
networks = self.client.networks()
2525
self.assertEqual(len(networks), initial_size + 1)
26-
self.assertTrue(net_id in [n['id'] for n in networks])
26+
self.assertTrue(net_id in [n['Id'] for n in networks])
2727

2828
networks_by_name = self.client.networks(names=[net_name])
29-
self.assertEqual([n['id'] for n in networks_by_name], [net_id])
29+
self.assertEqual([n['Id'] for n in networks_by_name], [net_id])
3030

3131
networks_by_partial_id = self.client.networks(ids=[net_id[:8]])
32-
self.assertEqual([n['id'] for n in networks_by_partial_id], [net_id])
32+
self.assertEqual([n['Id'] for n in networks_by_partial_id], [net_id])
3333

3434
def test_inspect_network(self):
3535
net_name, net_id = self.create_network()
3636

3737
net = self.client.inspect_network(net_id)
3838
self.assertEqual(net, {
39-
u'name': net_name,
40-
u'id': net_id,
41-
u'driver': 'bridge',
42-
u'containers': {},
39+
u'Name': net_name,
40+
u'Id': net_id,
41+
u'Driver': 'bridge',
42+
u'Containers': {},
43+
u'IPAM': {u'Config': [{}], u'Driver': 'default'},
44+
u'Options': {},
45+
u'Scope': 'local'
4346
})
4447

4548
def test_create_network_with_host_driver_fails(self):
@@ -65,17 +68,17 @@ def test_connect_and_disconnect_container(self):
6568
self.client.start(container)
6669

6770
network_data = self.client.inspect_network(net_id)
68-
self.assertFalse(network_data.get('containers'))
71+
self.assertFalse(network_data.get('Containers'))
6972

7073
self.client.connect_container_to_network(container, net_id)
7174
network_data = self.client.inspect_network(net_id)
7275
self.assertEqual(
73-
list(network_data['containers'].keys()),
76+
list(network_data['Containers'].keys()),
7477
[container['Id']])
7578

7679
self.client.disconnect_container_from_network(container, net_id)
7780
network_data = self.client.inspect_network(net_id)
78-
self.assertFalse(network_data.get('containers'))
81+
self.assertFalse(network_data.get('Containers'))
7982

8083
def test_connect_on_container_create(self):
8184
net_name, net_id = self.create_network()
@@ -90,9 +93,9 @@ def test_connect_on_container_create(self):
9093

9194
network_data = self.client.inspect_network(net_id)
9295
self.assertEqual(
93-
list(network_data['containers'].keys()),
96+
list(network_data['Containers'].keys()),
9497
[container['Id']])
9598

9699
self.client.disconnect_container_from_network(container, net_id)
97100
network_data = self.client.inspect_network(net_id)
98-
self.assertFalse(network_data.get('containers'))
101+
self.assertFalse(network_data.get('Containers'))

0 commit comments

Comments
 (0)