Skip to content

Commit 8ffa09b

Browse files
authored
Merge pull request #1576 from robkooper/1572-replicas-0
Fix if replicas is set to 0, Fixes #1572
2 parents f127a9f + 5f9a599 commit 8ffa09b

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

docker/types/services.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -407,7 +407,7 @@ def __init__(self, mode, replicas=None):
407407
'replicas can only be used for replicated mode'
408408
)
409409
self[mode] = {}
410-
if replicas:
410+
if replicas is not None:
411411
self[mode]['Replicas'] = replicas
412412

413413
@property

tests/unit/dockertypes_test.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -305,6 +305,12 @@ def test_replicated_replicas(self):
305305
assert mode.mode == 'replicated'
306306
assert mode.replicas == 21
307307

308+
def test_replicated_replicas_0(self):
309+
mode = ServiceMode('replicated', 0)
310+
assert mode == {'replicated': {'Replicas': 0}}
311+
assert mode.mode == 'replicated'
312+
assert mode.replicas == 0
313+
308314
def test_invalid_mode(self):
309315
with pytest.raises(InvalidArgument):
310316
ServiceMode('foobar')

0 commit comments

Comments
 (0)