Skip to content

Commit 93e02ab

Browse files
author
aiordache
committed
Revert "Support for docker.types.Placement.MaxReplicas (new in API 1.40) in Docker Swarm Service"
This reverts commit b701d5c.
1 parent aa2ea7f commit 93e02ab

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

docker/models/services.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -157,8 +157,6 @@ def create(self, image, command=None, **kwargs):
157157
constraints.
158158
preferences (list of tuple): :py:class:`~docker.types.Placement`
159159
preferences.
160-
maxreplicas (int): :py:class:`~docker.types.Placement` maxreplicas
161-
or (int) representing maximum number of replicas per node.
162160
platforms (list of tuple): A list of platform constraints
163161
expressed as ``(arch, os)`` tuples.
164162
container_labels (dict): Labels to apply to the container.
@@ -321,7 +319,6 @@ def list(self, **kwargs):
321319
'constraints',
322320
'preferences',
323321
'platforms',
324-
'maxreplicas',
325322
]
326323

327324

docker/types/services.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -659,12 +659,10 @@ class Placement(dict):
659659
are provided in order from highest to lowest precedence and
660660
are expressed as ``(strategy, descriptor)`` tuples. See
661661
:py:class:`PlacementPreference` for details.
662-
maxreplicas (int): Maximum number of replicas per node
663662
platforms (:py:class:`list` of tuple): A list of platforms
664663
expressed as ``(arch, os)`` tuples
665664
"""
666-
def __init__(self, constraints=None, preferences=None, maxreplicas=None,
667-
platforms=None):
665+
def __init__(self, constraints=None, preferences=None, platforms=None):
668666
if constraints is not None:
669667
self['Constraints'] = constraints
670668
if preferences is not None:
@@ -673,8 +671,6 @@ def __init__(self, constraints=None, preferences=None, maxreplicas=None,
673671
if isinstance(pref, tuple):
674672
pref = PlacementPreference(*pref)
675673
self['Preferences'].append(pref)
676-
if maxreplicas is not None:
677-
self['MaxReplicas'] = maxreplicas
678674
if platforms:
679675
self['Platforms'] = []
680676
for plat in platforms:

0 commit comments

Comments
 (0)