Skip to content

Commit a5490ad

Browse files
committed
Fix appveyor tests
Signed-off-by: Joffrey F <[email protected]>
1 parent ba46201 commit a5490ad

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

requirements.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ packaging==16.8
1111
pycparser==2.17
1212
pyOpenSSL==17.0.0
1313
pyparsing==2.2.0
14+
pypiwin32==219; sys_platform == 'win32' and python_version < '3.6'
15+
pypiwin32==220; sys_platform == 'win32' and python_version >= '3.6'
1416
requests==2.14.2
1517
six==1.10.0
1618
websocket-client==0.40.0

setup.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,16 +26,19 @@
2626
'docker-pycreds >= 0.2.1'
2727
]
2828

29-
if sys.platform == 'win32':
30-
requirements.append('pypiwin32 >= 219')
31-
3229
extras_require = {
3330
':python_version < "3.5"': 'backports.ssl_match_hostname >= 3.5',
3431
# While not imported explicitly, the ipaddress module is required for
3532
# ssl_match_hostname to verify hosts match with certificates via
3633
# ServerAltname: https://pypi.python.org/pypi/backports.ssl_match_hostname
3734
':python_version < "3.3"': 'ipaddress >= 1.0.16',
3835

36+
# win32 APIs if on Windows (required for npipe support)
37+
# Python 3.6 is only compatible with v220 ; Python < 3.5 is not supported
38+
# on v220 ; ALL versions are broken for v222 (as of 2018-01-26)
39+
':sys_platform == "win32" and python_version < "3.6"': 'pypiwin32==219',
40+
':sys_platform == "win32" and python_version >= "3.6"': 'pypiwin32==220',
41+
3942
# If using docker-py over TLS, highly recommend this option is
4043
# pip-installed or pinned.
4144

win32-requirements.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
11
-r requirements.txt
2-
pypiwin32>=219

0 commit comments

Comments
 (0)