Skip to content

Commit d5c4ce2

Browse files
committed
Use better version comparison function
Signed-off-by: Joffrey F <[email protected]>
1 parent 6b59dc6 commit d5c4ce2

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

docker/models/containers.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
from ..errors import (ContainerError, ImageNotFound,
55
create_unexpected_kwargs_error)
66
from ..types import HostConfig
7-
from ..utils import compare_version
7+
from ..utils import version_gte
88
from .images import Image
99
from .resource import Collection, Model
1010

@@ -691,8 +691,7 @@ def run(self, image, command=None, stdout=True, stderr=False,
691691
image = image.id
692692
detach = kwargs.pop("detach", False)
693693
if detach and remove:
694-
if compare_version("1.24",
695-
self.client.api._version) > 0:
694+
if version_gte(self.client.api._version, '1.25'):
696695
kwargs["auto_remove"] = True
697696
else:
698697
raise RuntimeError("The options 'detach' and 'remove' cannot "

0 commit comments

Comments
 (0)