Disallow incompatible combination stats(decode=True, stream=False)

Signed-off-by: Joffrey F <[email protected]>

Author: shin-

docker/api/container.py

@@ -1071,7 +1071,8 @@ def stats(self, container, decode=None, stream=True):
         Args:
             container (str): The container to stream statistics from
             decode (bool): If set to true, stream will be decoded into dicts
-                on the fly. False by default.
+                on the fly. Only applicable if ``stream`` is True.
+                False by default.
             stream (bool): If set to false, only the current stats will be
                 returned instead of a stream. True by default.
 
@@ -1085,6 +1086,10 @@ def stats(self, container, decode=None, stream=True):
             return self._stream_helper(self._get(url, stream=True),
                                        decode=decode)
         else:
+            if decode:
+                raise errors.InvalidArgument(
+                    "decode is only available in conjuction with stream=True"
+                )
             return self._result(self._get(url, params={'stream': False}),
                                 json=True)
 

docker/models/containers.py

@@ -385,7 +385,8 @@ def stats(self, **kwargs):
 
         Args:
             decode (bool): If set to true, stream will be decoded into dicts
-                on the fly. False by default.
+                on the fly. Only applicable if ``stream`` is True.
+                False by default.
             stream (bool): If set to false, only the current stats will be
                 returned instead of a stream. True by default.