Skip to content

Commit ea4fbd7

Browse files
thaJeztahchris-crone
authored andcommitted
Update to python 3.7 (buster) and use build-args
The build arg can be used to either test different versions, but also makes it easier to "grep" when upgrading versions. The output format of `gpg2 --list-secret-keys` changed in the version installed on Buster, so `grep` was replaced with `awk` to address the new output format; Debian Jessie: gpg2 --no-auto-check-trustdb --list-secret-keys /root/.gnupg/secring.gpg ------------------------ sec 1024D/A7B21401 2018-04-25 uid Sakuya Izayoi <[email protected]> ssb 1024g/C235E4CE 2018-04-25 Debian Buster: gpg2 --no-auto-check-trustdb --list-secret-keys /root/.gnupg/pubring.kbx ------------------------ sec dsa1024 2018-04-25 [SCA] 9781B87DAB042E6FD51388A5464ED987A7B21401 uid [ultimate] Sakuya Izayoi <[email protected]> ssb elg1024 2018-04-25 [E] Signed-off-by: Sebastiaan van Stijn <[email protected]>
1 parent 546bc63 commit ea4fbd7

File tree

5 files changed

+16
-7
lines changed

5 files changed

+16
-7
lines changed

Dockerfile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
FROM python:2.7
1+
ARG PYTHON_VERSION=2.7
2+
3+
FROM python:${PYTHON_VERSION}
24

35
RUN mkdir /src
46
WORKDIR /src

Dockerfile-docs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
FROM python:3.5
1+
ARG PYTHON_VERSION=3.7
2+
3+
FROM python:${PYTHON_VERSION}
24

35
ARG uid=1000
46
ARG gid=1000

Dockerfile-py3

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
FROM python:3.6
1+
ARG PYTHON_VERSION=3.7
2+
3+
FROM python:${PYTHON_VERSION}
24

35
RUN mkdir /src
46
WORKDIR /src

tests/Dockerfile

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
ARG PYTHON_VERSION=3.6
2-
FROM python:$PYTHON_VERSION-jessie
1+
ARG PYTHON_VERSION=3.7
2+
3+
FROM python:${PYTHON_VERSION}
34
RUN apt-get update && apt-get -y install \
45
gnupg2 \
56
pass \
@@ -8,7 +9,7 @@ RUN apt-get update && apt-get -y install \
89
COPY ./tests/gpg-keys /gpg-keys
910
RUN gpg2 --import gpg-keys/secret
1011
RUN gpg2 --import-ownertrust gpg-keys/ownertrust
11-
RUN yes | pass init $(gpg2 --no-auto-check-trustdb --list-secret-keys | grep ^sec | cut -d/ -f2 | cut -d" " -f1)
12+
RUN yes | pass init $(gpg2 --no-auto-check-trustdb --list-secret-key | awk '/^sec/{getline; $1=$1; print}')
1213
RUN gpg2 --check-trustdb
1314
ARG CREDSTORE_VERSION=v0.6.2
1415
RUN curl -sSL -o /opt/docker-credential-pass.tar.gz \

tests/Dockerfile-dind-certs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
FROM python:2.7
1+
ARG PYTHON_VERSION=2.7
2+
3+
FROM python:${PYTHON_VERSION}
24
RUN mkdir /tmp/certs
35
VOLUME /certs
46

0 commit comments

Comments
 (0)