Skip to content

Updates to enforce sign-in docs #21262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 29, 2024
Merged

Updates to enforce sign-in docs #21262

merged 3 commits into from
Oct 29, 2024

Conversation

@sarahsanders-docker
Copy link
Contributor

@sarahsanders-docker sarahsanders-docker commented Oct 28, 2024 •
edited by atlassian bot
Loading

Description

  • Part of the overall SSO doc overhaul
  • Fixed some clarity and consistency issues (ex: referring to sign-in enforcement methods as methods consistently)
  • Added some clarity and context in the Methods guide before steps

Related issues or tickets

ENGDOCS-2271

Reviews

  • Editorial review

@sarahsanders-docker sarahsanders-docker requested a review from a team October 28, 2024 20:54
@netlify
Copy link

netlify bot commented Oct 28, 2024 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 7e822b4
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6720ff8333ca590009943988
😎 Deploy Preview https://deploy-preview-21262--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

aevesdocker
aevesdocker reviewed Oct 29, 2024
View reviewed changes
aevesdocker
aevesdocker approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarahsanders-docker sarahsanders-docker merged commit d81afd8 into docker:main Oct 29, 2024
14 checks passed
@sarahsanders-docker sarahsanders-docker deleted the ENGDOCS-2271 branch December 18, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aevesdocker aevesdocker aevesdocker approved these changes

Assignees

No one assigned

Labels

area/security status/review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sarahsanders-docker @aevesdocker