Skip to content

Conversation

@aevesdocker
Copy link
Contributor

@aevesdocker aevesdocker commented Nov 13, 2024

Description

Replaces #20646 that was so old it was still using the toc.yaml file.
SME reviews complete. Just need editorial

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@netlify
Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 212b9c0
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/673c9a6963b9170008970714
😎 Deploy Preview https://deploy-preview-21419--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/security area/scout Relates to Docker Scout area/guides labels Nov 13, 2024
@aevesdocker aevesdocker marked this pull request as ready for review November 13, 2024 12:39
@aevesdocker aevesdocker requested a review from dvdksn as a code owner November 13, 2024 12:39
@aevesdocker aevesdocker added this to the 4.36 milestone Nov 13, 2024
@aevesdocker aevesdocker requested a review from a team November 13, 2024 12:40
Copy link
Contributor

@sarahsanders-docker sarahsanders-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! left a few nits but overall the information is clear and easy to follow :)

@aevesdocker
Copy link
Contributor Author

Thanks for those fresh eyes @sarahsanders-docker, have incorporated your suggestions

Copy link
Contributor

@sarahsanders-docker sarahsanders-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@aevesdocker aevesdocker merged commit 42d97aa into docker:main Nov 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/guides area/scout Relates to Docker Scout area/security area/tests status/review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants